From patchwork Fri Jan 27 13:56:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Ujfalusi X-Patchwork-Id: 9541893 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 729B260429 for ; Fri, 27 Jan 2017 13:57:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 64AF927F07 for ; Fri, 27 Jan 2017 13:57:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 58F9127F54; Fri, 27 Jan 2017 13:57:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8BB4527F07 for ; Fri, 27 Jan 2017 13:57:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932293AbdA0N4m (ORCPT ); Fri, 27 Jan 2017 08:56:42 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:21027 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754742AbdA0N4i (ORCPT ); Fri, 27 Jan 2017 08:56:38 -0500 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by fllnx210.ext.ti.com (8.15.1/8.15.1) with ESMTP id v0RDtp2m031266; Fri, 27 Jan 2017 07:55:51 -0600 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v0RDtpnS010676; Fri, 27 Jan 2017 07:55:51 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.294.0; Fri, 27 Jan 2017 07:55:50 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v0RDtmuJ005458; Fri, 27 Jan 2017 07:55:48 -0600 Subject: Re: omapdrm with n900 To: Tony Lindgren , Jarkko Nikula References: <20170125015709.GH7403@atomide.com> <20170125175011.GI7403@atomide.com> <20170126084559.GA2196@bitmer.com> <20170126150704.GN7403@atomide.com> <20170126171701.GT7403@atomide.com> CC: Tomi Valkeinen , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Pavel Machek , Sebastian Reichel , From: Peter Ujfalusi Message-ID: <7a0116a5-4d2f-0b6e-e2d0-4747d4488184@ti.com> Date: Fri, 27 Jan 2017 15:56:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170126171701.GT7403@atomide.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Tony, On 01/26/2017 07:17 PM, Tony Lindgren wrote: > * Tony Lindgren [170126 07:08]: >> * Jarkko Nikula [170126 00:47]: >>> On Thu, Jan 26, 2017 at 09:39:52AM +0200, Tomi Valkeinen wrote: >>>> On 25/01/17 19:50, Tony Lindgren wrote: >>>> >>>>>>> The LCD just stays blank with backlight off as soon as I load >>>>>>> panel_sony_acx565akm. >>>>>> >>>>>> Can you share the kernel logs for both boards? I don't have neither >>>>>> board, so I probably can't help too much here. >>>>> >>>>> Below are the relevant parts for both devices using v4.10-rc5. >>>> >>>> The logs look quite similar, and I don't see anything wrong there. >>>> >>>> Jarkko, you sent a patch for N900's panel a while ago, do you have the >>>> LCD working with omapdrm? >>>> >>> Yes I have but after probing the panel there has to do blank-unblank >>> cycle and I think setting the blacklight level too. I was going to check >>> it when that regression happened but didn't find time to do it yet. >> >> I've tried these too, no luck. Maybe I'm using the wrong sequence. >> >> Could it be that some of the GPIOs get toggled the wrong way around? > > Sorry Jarkko, you're right. This gets it working: > > # modprobe tsc2005 > # modprobe panel_sony_acx565akm > # modprobe omapdrm > # echo 255 > /sys/class/backlight/acx565akm/brightness > # echo 0 > /sys/class/graphics/fb0/blank > # echo 1 > /sys/class/graphics/fb0/blank > # echo 0 > /sys/class/graphics/fb0/blank > > That extra blank/unblank cycle seems a bit user unfriendly? most likely this will help: - Péter --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c b/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c index 5ab39e0060f2..d5a21a96ea82 100644 --- a/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c +++ b/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c @@ -839,7 +839,7 @@ static int acx565akm_probe(struct spi_device *spi) bldev->props.max_brightness = max_brightness; bldev->props.brightness = brightness; - acx565akm_bl_update_status(bldev); + backlight_update_status(bldev); ddata->vm = acx565akm_panel_vm;