From patchwork Fri Jul 6 14:13:06 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 1166191 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id E25133FE80 for ; Fri, 6 Jul 2012 14:13:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757337Ab2GFOND (ORCPT ); Fri, 6 Jul 2012 10:13:03 -0400 Received: from na3sys009aog135.obsmtp.com ([74.125.149.84]:60642 "EHLO na3sys009aog135.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752839Ab2GFONB (ORCPT ); Fri, 6 Jul 2012 10:13:01 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]) (using TLSv1) by na3sys009aob135.postini.com ([74.125.148.12]) with SMTP ID DSNKT/byaAHDhFdKmsQdFVsGNANUmHicnI7y@postini.com; Fri, 06 Jul 2012 07:13:01 PDT Received: by pbbro12 with SMTP id ro12so17688665pbb.18 for ; Fri, 06 Jul 2012 07:12:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version:content-type:x-gm-message-state; bh=/qe7jGRJHasu78NQjpnIrFMSbBpNSG8ITP51IDS5cds=; b=Uda9/azJom4SE2meiF5WEIcMgDLJ6gJxCnC3ATD3IGxfWxJhx5+g2VkXEGtQjNnIw2 Wu8lknFU8+hynsg1t9RSi/yu2Ii3njWWhPJGJbuq0K+5cSCAr/3cNCCLA4GJD0jQR/I2 k2pV1piKRpXzq+FjfZ63g6PWzB7J7r81kVzzWFjXvevP+tHNbM96erq+WIt5keUQdJ2H 8w/4kCQ/FJ/uCtwjjC/uxDaorMkJsPJo67wUpZO+66zkXQu0VjkW5C4+ZA0sI/WUOCwV 2d54C4BZH/7cFjZe60XwWh7rInZzHNSdwcUJKycuWSxA4UiK586lZg3GlMdXImZrq2ge GZQA== Received: by 10.68.203.40 with SMTP id kn8mr37123802pbc.162.1341583973096; Fri, 06 Jul 2012 07:12:53 -0700 (PDT) Received: from localhost (c-24-19-7-36.hsd1.wa.comcast.net. [24.19.7.36]) by mx.google.com with ESMTPS id os3sm21951426pbb.41.2012.07.06.07.12.51 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 06 Jul 2012 07:12:51 -0700 (PDT) From: Kevin Hilman To: Keshava Munegowda Cc: , , , , Subject: Re: [PATCH] OMAP: config : disable the usb host configuration in omap2plus_defconfig Organization: Texas Instruments, Inc. References: <1341575380-11972-1-git-send-email-keshava_mgowda@ti.com> Date: Fri, 06 Jul 2012 07:13:06 -0700 In-Reply-To: <1341575380-11972-1-git-send-email-keshava_mgowda@ti.com> (Keshava Munegowda's message of "Fri, 6 Jul 2012 17:19:40 +0530") Message-ID: <87d349c70t.fsf@ti.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 X-Gm-Message-State: ALoCoQl3HESMtgb1lZOOzxmEY4V0Wpwk4nIZzW0cAppc3hn9MfcFpqy3wbbmll5gdGUeE1UjBwxp Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Keshava Munegowda writes: > The usb host is disabled in the omap2 build; This is because > usb host is causing the retention to break in cpu idle. ... and causes warnings during boot, and hangs in suspend, can't suspend using NFSroot, etc. etc. Thank you for disabling this by default, But I don't think this fix is targetted enough (more below.) Tony, when v3.5 came out, I asked them to fix this properly, but nothing was done. So I've resorted to requesting that this feature be disabled by default since it introduced PM regressions. Of course, I'd like to see this fixed properly instead, but we've run out of time for v3.5 and IMO, this PM regression needs to be fixed for v3.5. See my more targetted patches below. > Signed-off-by: Keshava Munegowda > --- > arch/arm/configs/omap2plus_defconfig | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig > index 9854ff4..7b32da6 100644 > --- a/arch/arm/configs/omap2plus_defconfig > +++ b/arch/arm/configs/omap2plus_defconfig > @@ -170,17 +170,6 @@ CONFIG_SND_USB_AUDIO=m > CONFIG_SND_SOC=m > CONFIG_SND_OMAP_SOC=m > CONFIG_SND_OMAP_SOC_OMAP3_PANDORA=m > -CONFIG_USB=y > -CONFIG_USB_DEBUG=y > -CONFIG_USB_ANNOUNCE_NEW_DEVICES=y > -CONFIG_USB_DEVICEFS=y > -CONFIG_USB_SUSPEND=y > -CONFIG_USB_MON=y > -CONFIG_USB_EHCI_HCD=y > -CONFIG_USB_WDM=y > -CONFIG_USB_STORAGE=y > -CONFIG_USB_LIBUSUAL=y > -CONFIG_USB_TEST=y Why disable all of these? With that, it's not terribly clear what is going on, or why. Instead, what you need is a targetted fix to just disable the problem driver by default: Either this: Will have the inteded affect with the benefit of being much clearer about what is actually being disabled, and why. Kevin --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig index 9854ff4..11828e6 100644 --- a/arch/arm/configs/omap2plus_defconfig +++ b/arch/arm/configs/omap2plus_defconfig @@ -176,7 +176,6 @@ CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_DEVICEFS=y CONFIG_USB_SUSPEND=y CONFIG_USB_MON=y -CONFIG_USB_EHCI_HCD=y CONFIG_USB_WDM=y CONFIG_USB_STORAGE=y CONFIG_USB_LIBUSUAL=y or this: diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index e129c82..3747826 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -825,7 +825,7 @@ config MFD_WL1273_CORE config MFD_OMAP_USB_HOST bool "Support OMAP USBHS core driver" depends on USB_EHCI_HCD_OMAP || USB_OHCI_HCD_OMAP3 - default y + default n help This is the core driver for the OAMP EHCI and OHCI drivers. This MFD driver does the required setup functionalities for