From patchwork Mon Oct 17 11:50:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 9379045 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B4698600CA for ; Mon, 17 Oct 2016 11:52:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A678D28D4D for ; Mon, 17 Oct 2016 11:52:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9AC6628D9B; Mon, 17 Oct 2016 11:52:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_TVD_MIME_EPI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D1F828D4D for ; Mon, 17 Oct 2016 11:52:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932717AbcJQLwS (ORCPT ); Mon, 17 Oct 2016 07:52:18 -0400 Received: from mga14.intel.com ([192.55.52.115]:58360 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932550AbcJQLwQ (ORCPT ); Mon, 17 Oct 2016 07:52:16 -0400 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 17 Oct 2016 04:51:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,357,1473145200"; d="asc'?scan'208";a="1054935734" Received: from pipin.fi.intel.com (HELO localhost) ([10.237.68.37]) by fmsmga001.fm.intel.com with ESMTP; 17 Oct 2016 04:51:23 -0700 From: Felipe Balbi To: kbuild test robot , Linus Walleij Cc: kbuild-all@01.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [balbi-usb:testing/next 57/84] drivers/usb/dwc3/dwc3-st.c:328:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' In-Reply-To: <201610171915.7Qg5kFu7%fengguang.wu@intel.com> References: <201610171915.7Qg5kFu7%fengguang.wu@intel.com> Date: Mon, 17 Oct 2016 14:50:39 +0300 Message-ID: <87funvry7k.fsf@linux.intel.com> MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, kbuild test robot writes: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next > head: 4281ef86fae986e0a9bb553fb311fe6d8e039118 > commit: 040f47e7330045feaa8c06bf2900db2eb2038e80 [57/84] usb: dwc3: Kconfig: allow all glues to build if COMPILE_TEST > config: blackfin-allmodconfig (attached as .config) > compiler: bfin-uclinux-gcc (GCC) 6.2.0 > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout 040f47e7330045feaa8c06bf2900db2eb2038e80 > # save the attached .config to linux build tree > make.cross ARCH=blackfin > > All errors (new ones prefixed by >>): > > drivers/usb/dwc3/dwc3-st.c: In function 'st_dwc3_suspend': >>> drivers/usb/dwc3/dwc3-st.c:328:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration] > pinctrl_pm_select_sleep_state(dev); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/usb/dwc3/dwc3-st.c: In function 'st_dwc3_resume': >>> drivers/usb/dwc3/dwc3-st.c:338:2: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration] > pinctrl_pm_select_default_state(dev); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors looks like a bug in . Something along the lines of below should be enough: Linus, do you want me to send this as a proper patch? It's pretty clear that currently we can have build regressions with these helpers. Was it a conscious choice to not provide stubs or just a slip? diff --git a/include/linux/pinctrl/consumer.h b/include/linux/pinctrl/consumer.h index d7e5d608faa7..c8aa03aa1c42 100644 --- a/include/linux/pinctrl/consumer.h +++ b/include/linux/pinctrl/consumer.h @@ -44,7 +44,9 @@ extern void devm_pinctrl_put(struct pinctrl *p); extern int pinctrl_pm_select_default_state(struct device *dev); extern int pinctrl_pm_select_sleep_state(struct device *dev); extern int pinctrl_pm_select_idle_state(struct device *dev); -#else +#endif + +#else /* !CONFIG_PINCTRL */ static inline int pinctrl_pm_select_default_state(struct device *dev) { return 0; @@ -57,9 +59,6 @@ static inline int pinctrl_pm_select_idle_state(struct device *dev) { return 0; } -#endif - -#else /* !CONFIG_PINCTRL */ static inline int pinctrl_request_gpio(unsigned gpio) {