From patchwork Mon May 3 16:15:35 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 96510 X-Patchwork-Delegate: khilman@deeprootsystems.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o43GFvSk007487 for ; Mon, 3 May 2010 16:15:57 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933167Ab0ECQPk (ORCPT ); Mon, 3 May 2010 12:15:40 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:50028 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933161Ab0ECQPj (ORCPT ); Mon, 3 May 2010 12:15:39 -0400 Received: by pwj9 with SMTP id 9so1273882pwj.19 for ; Mon, 03 May 2010 09:15:39 -0700 (PDT) Received: by 10.142.67.35 with SMTP id p35mr9109796wfa.203.1272903338798; Mon, 03 May 2010 09:15:38 -0700 (PDT) Received: from localhost (deeprootsystems.com [216.254.16.51]) by mx.google.com with ESMTPS id 21sm4769672pzk.0.2010.05.03.09.15.36 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 03 May 2010 09:15:37 -0700 (PDT) To: Nishanth Menon Cc: linux-omap , Peter Tseng Subject: Re: [PATCH] OMAP3: PM: quickly hack fix up init_opp References: <1272728589-5313-1-git-send-email-nm@ti.com> From: Kevin Hilman Organization: Deep Root Systems, LLC Date: Mon, 03 May 2010 09:15:35 -0700 In-Reply-To: <1272728589-5313-1-git-send-email-nm@ti.com> (Nishanth Menon's message of "Sat\, 1 May 2010 10\:43\:09 -0500") Message-ID: <87hbmp6jx4.fsf@deeprootsystems.com> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Mon, 03 May 2010 16:15:57 +0000 (UTC) diff --git a/arch/arm/mach-omap2/resource34xx.c b/arch/arm/mach-omap2/resource34xx.c index ae8bd09..2bc5694 100644 --- a/arch/arm/mach-omap2/resource34xx.c +++ b/arch/arm/mach-omap2/resource34xx.c @@ -533,7 +533,7 @@ void init_freq(struct shared_resource *resp) { char *linked_res_name; int ret = -EINVAL; - unsigned long freq; + unsigned long freq = 0; resp->no_of_users = 0; linked_res_name = (char *)resp->resource_data; @@ -546,7 +546,8 @@ void init_freq(struct shared_resource *resp) else if (strcmp(resp->name, "dsp_freq") == 0) /* DSP freq in Mhz */ ret = opp_to_freq(&freq, OPP_DSP, curr_vdd1_opp); - BUG_ON(ret); + if (ret) + pr_err("%s: initializing frequency failed!\n", __func__); resp->curr_level = freq; return;