From patchwork Thu Nov 9 10:59:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 10050783 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2E873601EB for ; Thu, 9 Nov 2017 10:59:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2040529A56 for ; Thu, 9 Nov 2017 10:59:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1518629A86; Thu, 9 Nov 2017 10:59:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_TVD_MIME_EPI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 931BC29A56 for ; Thu, 9 Nov 2017 10:59:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753000AbdKIK7d (ORCPT ); Thu, 9 Nov 2017 05:59:33 -0500 Received: from mga11.intel.com ([192.55.52.93]:41959 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752827AbdKIK7c (ORCPT ); Thu, 9 Nov 2017 05:59:32 -0500 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Nov 2017 02:59:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,369,1505804400"; d="asc'?scan'208";a="1241956994" Received: from pipin.fi.intel.com (HELO localhost) ([10.237.68.37]) by fmsmga002.fm.intel.com with ESMTP; 09 Nov 2017 02:59:30 -0800 From: Felipe Balbi To: Greg Kroah-Hartman , Tony Lindgren Cc: Stephen Rothwell , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: USB regression in next-20171108 with hub spamming In-Reply-To: <87shdnrak7.fsf@linux.intel.com> References: <20171108230511.GY28152@atomide.com> <20171109080007.GA17098@kroah.com> <871sl7sq9i.fsf@linux.intel.com> <87wp2zrasg.fsf@linux.intel.com> <87shdnrak7.fsf@linux.intel.com> Date: Thu, 09 Nov 2017 12:59:25 +0200 Message-ID: <87po8rra42.fsf@linux.intel.com> MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, Felipe Balbi writes: > Felipe Balbi writes: > >> Felipe Balbi writes: >> >>> Hi, >>> >>> Greg Kroah-Hartman writes: >>>> On Wed, Nov 08, 2017 at 03:05:11PM -0800, Tony Lindgren wrote: >>>>> Hi Felipe & Greg, >>>>> >>>>> Looks like in next-20171108 USB hub is spamming console about once a >>>>> second after commit 7dfd74fd128 ("Merge remote-tracking branch >>>>> 'usb/usb-next'"). >>>>> >>>>> Any ideas? See the log below. >>>> >>>> Any chance you can run 'git bisect'? >>> >>> I wonder if it was caused by the usb_get_std_status() changes. We didn't >>> catch this in our testing, though. I left the patches in intel's >>> validation for a few days before sending out. >>> >>> Let me compile that very tag and try it with one of our machines. >>> >>> Tony, a bisection would be useful, indeed. >> >> reproduced. Digging to figure out what's going on. > > Okay, found it. Testing a patch. Here's the patch, I'll send it formally shortly. diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c index 0cdc463c9509..c15fbf76f8f7 100644 --- a/drivers/usb/core/message.c +++ b/drivers/usb/core/message.c @@ -975,6 +975,7 @@ int usb_get_status(struct usb_device *dev, int recip, int type, int target, } *(u32 *) data = le32_to_cpu(*(__le32 *) status); + ret = 0; break; case 2: if (type != USB_STATUS_TYPE_STANDARD) { @@ -983,6 +984,7 @@ int usb_get_status(struct usb_device *dev, int recip, int type, int target, } *(u16 *) data = le16_to_cpu(*(__le16 *) status); + ret = 0; break; default: ret = -EIO;