From patchwork Tue May 25 22:18:13 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 102302 X-Patchwork-Delegate: khilman@deeprootsystems.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o4PMIh0D008717 for ; Tue, 25 May 2010 22:18:43 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932370Ab0EYWST (ORCPT ); Tue, 25 May 2010 18:18:19 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:53107 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759020Ab0EYWSR convert rfc822-to-8bit (ORCPT ); Tue, 25 May 2010 18:18:17 -0400 Received: by pwi2 with SMTP id 2so1270512pwi.19 for ; Tue, 25 May 2010 15:18:17 -0700 (PDT) Received: by 10.114.189.18 with SMTP id m18mr6779308waf.28.1274825896032; Tue, 25 May 2010 15:18:16 -0700 (PDT) Received: from localhost (c-24-18-179-55.hsd1.wa.comcast.net [24.18.179.55]) by mx.google.com with ESMTPS id 33sm51202390wad.20.2010.05.25.15.18.15 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 25 May 2010 15:18:15 -0700 (PDT) To: Mike Frysinger Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-omap@vger.kernel.org, Michael Roth , Pavel Machek , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] touchscreen: ads7846: please don't touch free'd memory References: <1274226413-8520-1-git-send-email-khilman@deeprootsystems.com> <20100519000019.GA17475@core.coreip.homeip.net> <87mxvnlpxv.fsf@deeprootsystems.com> <20100525202135.GC4455@core.coreip.homeip.net> <8739xflkn5.fsf@deeprootsystems.com> From: Kevin Hilman Organization: Deep Root Systems, LLC Date: Tue, 25 May 2010 15:18:13 -0700 In-Reply-To: (Mike Frysinger's message of "Tue\, 25 May 2010 17\:56\:27 -0400") Message-ID: <87r5kzk4m2.fsf@deeprootsystems.com> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Tue, 25 May 2010 22:18:43 +0000 (UTC) diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c index 532279c..634f6f6 100644 --- a/drivers/input/touchscreen/ads7846.c +++ b/drivers/input/touchscreen/ads7846.c @@ -1163,8 +1163,8 @@ static int __devinit ads7846_probe(struct spi_device *spi) ts->reg = regulator_get(&spi->dev, "vcc"); if (IS_ERR(ts->reg)) { - dev_err(&spi->dev, "unable to get regulator: %ld\n", - PTR_ERR(ts->reg)); + err = PTR_ERR(ts->reg); + dev_err(&spi->dev, "unable to get regulator: %ld\n", err); goto err_free_gpio; }