From patchwork Fri Jul 22 20:19:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 1001002 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p6MKJWtX005472 for ; Fri, 22 Jul 2011 20:19:32 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932098Ab1GVUTZ (ORCPT ); Fri, 22 Jul 2011 16:19:25 -0400 Received: from na3sys009aog107.obsmtp.com ([74.125.149.197]:59916 "EHLO na3sys009aog107.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755132Ab1GVUTY (ORCPT ); Fri, 22 Jul 2011 16:19:24 -0400 Received: from mail-gy0-f180.google.com ([209.85.160.180]) (using TLSv1) by na3sys009aob107.postini.com ([74.125.148.12]) with SMTP ID DSNKTinbS5QJScBKcSeHZIfL3zpTT2T73E7V@postini.com; Fri, 22 Jul 2011 13:19:24 PDT Received: by mail-gy0-f180.google.com with SMTP id 4so2033781gyg.25 for ; Fri, 22 Jul 2011 13:19:23 -0700 (PDT) Received: by 10.68.60.104 with SMTP id g8mr2835424pbr.132.1311365963622; Fri, 22 Jul 2011 13:19:23 -0700 (PDT) Received: from localhost (c-24-19-7-36.hsd1.wa.comcast.net [24.19.7.36]) by mx.google.com with ESMTPS id p7sm2035157pbn.81.2011.07.22.13.19.22 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 22 Jul 2011 13:19:22 -0700 (PDT) From: Kevin Hilman To: Sergei Shtylyov Cc: linux-omap@vger.kernel.org, Paul Walmsley , Grant Likely , "G. Manjunath Kondaiah" , devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices Organization: Texas Instruments, Inc. References: <1311292338-11830-1-git-send-email-khilman@ti.com> <1311292338-11830-5-git-send-email-khilman@ti.com> <4E296DFB.3010205@ru.mvista.com> Date: Fri, 22 Jul 2011 13:19:21 -0700 In-Reply-To: <4E296DFB.3010205@ru.mvista.com> (Sergei Shtylyov's message of "Fri, 22 Jul 2011 16:32:59 +0400") Message-ID: <87y5zqysom.fsf@ti.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 22 Jul 2011 20:19:32 +0000 (UTC) Hi Sergei, Sergei Shtylyov writes: > On 22-07-2011 3:52, Kevin Hilman wrote: > >> For converting from struct device to platform_device, and from >> platform_device to struct device, > > You mean from platform_device to omap_device? > Yes indeed, thanks. Updated patch below (only changelog changed) Kevin From e3996fdb48e6850bc3f2a383e86fe67be5796d40 Mon Sep 17 00:00:00 2001 From: Kevin Hilman Date: Thu, 21 Jul 2011 14:03:51 -0700 Subject: [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices For converting from struct device to platform_device, and from platform_device to struct omap_device, there are existing macros. Use them instead of manual use of container_of(). Signed-off-by: Kevin Hilman --- arch/arm/plat-omap/mcbsp.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c index 6c62af1..02199e8 100644 --- a/arch/arm/plat-omap/mcbsp.c +++ b/arch/arm/plat-omap/mcbsp.c @@ -260,9 +260,9 @@ EXPORT_SYMBOL(omap_mcbsp_dma_reg_params); #ifdef CONFIG_ARCH_OMAP3 static struct omap_device *find_omap_device_by_dev(struct device *dev) { - struct platform_device *pdev = container_of(dev, - struct platform_device, dev); - return container_of(pdev, struct omap_device, pdev); + struct platform_device *pdev = to_platform_device(dev); + + return to_omap_device(pdev); } static void omap_st_on(struct omap_mcbsp *mcbsp)