From patchwork Sat May 28 09:24:17 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tasslehoff Kjappfot X-Patchwork-Id: 826032 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p4S9OQjT001172 for ; Sat, 28 May 2011 09:24:26 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751458Ab1E1JYV (ORCPT ); Sat, 28 May 2011 05:24:21 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:40134 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750771Ab1E1JYU convert rfc822-to-8bit (ORCPT ); Sat, 28 May 2011 05:24:20 -0400 Received: by ewy4 with SMTP id 4so879183ewy.19 for ; Sat, 28 May 2011 02:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:subject:mime-version:content-type:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to:x-mailer; bh=bLgLFjtWxfwS3RVedEDaSvvcv70S9PCN0JlrFsNkiXQ=; b=YyVtL8+FGps6bsMEbWJyMb9vrhch4j4OJZSHNO60L2o7ahFauPPTtBjo30oS/wH+GB it0xN74x8OnqLMIeS9//G/U3p7kVqvH/HP2tiIp3gs/edx3oP3Ga+oXTphYzqJtS2NoX wEZD+w4V/fl4qb0COoybsrGkzzge0l4QoRxEI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=KsfupqTfY+AD2Ok0v808mnLPCa7dv1NWcUvqVs4OYvJaZFTxgn/z0SmMSBH0rheeyR oKm/cmtLDerXa7L2Otu2WhJtQOMWzXnxsXmTWTmqtrEHkw44Pc51KZEm/dXMpkETXUEY jf6JpCIyfywMx84t4Symj5+VPA1qomW5lFM0s= Received: by 10.213.14.209 with SMTP id h17mr1118229eba.23.1306574659374; Sat, 28 May 2011 02:24:19 -0700 (PDT) Received: from [192.168.10.120] (145.79-161-31.customer.lyse.net [79.161.31.145]) by mx.google.com with ESMTPS id a45sm1815738eec.9.2011.05.28.02.24.18 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 28 May 2011 02:24:18 -0700 (PDT) Subject: Re: [PATCH] free rev gpios when they are read, so others can read them later Mime-Version: 1.0 (Apple Message framework v1084) From: Tasslehoff Kjappfot In-Reply-To: <4DDF8AC9.60709@compulab.co.il> Date: Sat, 28 May 2011 11:24:17 +0200 Cc: linux-omap@vger.kernel.org Message-Id: <91831E5F-5654-4133-AADC-9C3D6B86A63E@gmail.com> References: <1306438716-68265-1-git-send-email-tasskjapp@gmail.com> <2DCF0893-4166-4604-887B-EDBC3643290A@gmail.com> <4DDF8AC9.60709@compulab.co.il> To: Igor Grinberg X-Mailer: Apple Mail (2.1084) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Sat, 28 May 2011 09:24:26 +0000 (UTC) Hi Igor. > > To be consistent with the rest of the file, > can the white space here be "tabs" instead of spaces? > > > -- > Regards, > Igor. > They can. New version attached. I'm don't know how to use git send-email to continue this thread with a comment to my patch, so it was done manually. Let me know if something else is less-than-optimal with my patches. Rookie contributor :) Signed-off-by: Tasslehoff Kjappfot --- arch/arm/mach-omap2/board-omap3beagle.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c index 3ff3a2c..54dbb7dd 100644 --- a/arch/arm/mach-omap2/board-omap3beagle.c +++ b/arch/arm/mach-omap2/board-omap3beagle.c @@ -106,6 +106,9 @@ static void __init omap3_beagle_init_rev(void) beagle_rev = gpio_get_value(171) | (gpio_get_value(172) << 1) | (gpio_get_value(173) << 2); + gpio_free_array(omap3_beagle_rev_gpios, + ARRAY_SIZE(omap3_beagle_rev_gpios)); + switch (beagle_rev) { case 7: printk(KERN_INFO "OMAP3 Beagle Rev: Ax/Bx\n");