From patchwork Mon Jul 2 05:54:57 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kim, Milo" X-Patchwork-Id: 1145511 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id EA942DFFD2 for ; Mon, 2 Jul 2012 05:55:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932128Ab2GBFzi (ORCPT ); Mon, 2 Jul 2012 01:55:38 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:47948 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932066Ab2GBFzh convert rfc822-to-8bit (ORCPT ); Mon, 2 Jul 2012 01:55:37 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id q625t3Ku019162; Mon, 2 Jul 2012 00:55:03 -0500 Received: from DQHE72.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id q625sx0R000102; Mon, 2 Jul 2012 11:25:00 +0530 (IST) Received: from DQHE02.ent.ti.com ([fe80::19f9:3779:aee:e323]) by DQHE72.ent.ti.com ([fe80::d460:f2d1:b611:d690%22]) with mapi id 14.01.0323.003; Mon, 2 Jul 2012 13:54:58 +0800 From: "Kim, Milo" To: "tony@atomide.com" CC: "linux-omap@vger.kernel.org" , "mgreer@animalcreek.com" , "paul@pwsan.com" , "linux-kernel@vger.kernel.org" Subject: [PATCH] ARM: OMAP AM35x: clockdomain data: fix resolving dependency problem Thread-Topic: [PATCH] ARM: OMAP AM35x: clockdomain data: fix resolving dependency problem Thread-Index: Ac1YFzSz7oPLHyT4Q46Oe8rXkWtZLw== Date: Mon, 2 Jul 2012 05:54:57 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.34.32] MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org In am35x board , iva2 clock domain doesn't be used. So mpu_am35x_clkdm should be used rather than mpu_3xxx_clkdm. OMAP3430 : mpu_3xxx_clkdm (with iva2 clkdm) AM35x : mpu_am35x_clkdm (without iva2 clkdm) For the compatibility with omap3430, this patch has no conflict because mpu_3xxx_clkdm was already defined in clock domains for omap3430. So this can be removed from common clock domain. Below error can be fixed with this patch. [ 0.000000] AM3517 ES1.1 (l2cache sgx neon ) [ 0.000000] ------------[ cut here ]------------ [ 0.000000] WARNING: at arch/arm/mach-omap2/clockdomain.c:237 _resolve_clkdm_deps+0x68/0x108() [ 0.000000] clockdomain: mpu_clkdm: could not find clkdm iva2_clkdm while resolving dependencies - should never happen [ 0.000000] Modules linked in: [ 0.000000] [] (unwind_backtrace+0x0/0xf4) from [] (warn_slowpath_common+0x4c/0x64) [ 0.000000] [] (warn_slowpath_common+0x4c/0x64) from [] (warn_slowpath_fmt+0x30/0x40) [ 0.000000] [] (warn_slowpath_fmt+0x30/0x40) from [] (_resolve_clkdm_deps+0x68/0x108) [ 0.000000] [] (_resolve_clkdm_deps+0x68/0x108) from [] (clkdm_complete_init+0x34/0x90) [ 0.000000] [] (clkdm_complete_init+0x34/0x90) from [] (omap3_init_early+0x20/0x30) [ 0.000000] [] (omap3_init_early+0x20/0x30) from [] (setup_arch+0x834/0x94c) [ 0.000000] [] (setup_arch+0x834/0x94c) from [] (start_kernel+0x88/0x2fc) [ 0.000000] [] (start_kernel+0x88/0x2fc) from [<80008044>] (0x80008044) Signed-off-by: Milo(Woogyom) Kim --- arch/arm/mach-omap2/clockdomains3xxx_data.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/clockdomains3xxx_data.c b/arch/arm/mach-omap2/clockdomains3xxx_data.c index d625844..56089c4 100644 --- a/arch/arm/mach-omap2/clockdomains3xxx_data.c +++ b/arch/arm/mach-omap2/clockdomains3xxx_data.c @@ -454,7 +454,6 @@ static struct clkdm_autodep clkdm_am35x_autodeps[] = { static struct clockdomain *clockdomains_common[] __initdata = { &wkup_common_clkdm, - &mpu_3xxx_clkdm, &neon_clkdm, &core_l3_3xxx_clkdm, &core_l4_3xxx_clkdm,