From patchwork Tue Sep 22 14:31:05 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "C.A, Subramaniam" X-Patchwork-Id: 49313 X-Patchwork-Delegate: tony@atomide.com Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n8MEVAMS027695 for ; Tue, 22 Sep 2009 14:31:10 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754073AbZIVObF (ORCPT ); Tue, 22 Sep 2009 10:31:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754673AbZIVObF (ORCPT ); Tue, 22 Sep 2009 10:31:05 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:49246 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753659AbZIVObE convert rfc822-to-8bit (ORCPT ); Tue, 22 Sep 2009 10:31:04 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id n8MEUwku008196; Tue, 22 Sep 2009 09:30:59 -0500 Received: from dbde70.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id n8MEUvxr028428; Tue, 22 Sep 2009 20:00:57 +0530 (IST) Received: from dbde02.ent.ti.com ([172.24.170.145]) by dbde70.ent.ti.com ([172.24.170.148]) with mapi; Tue, 22 Sep 2009 20:00:57 +0530 From: "C.A, Subramaniam" To: "linux-omap@vger.kernel.org" CC: Hiroshi DOYU , "tony@atomide.com" , "rmk@arm.linux.org.uk" , "Kanigeri, Hari" , "Gupta, Ramesh" Date: Tue, 22 Sep 2009 20:01:05 +0530 Subject: [PATCH 5/10] omap mailbox: remove disable_/enable_mbox_irq in isr Thread-Topic: [PATCH 5/10] omap mailbox: remove disable_/enable_mbox_irq in isr Thread-Index: Aco7kVFpdPklESJSSWykRdBvQn6OLw== Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org From d9bcb084bfdfdd72a4b449ca4c5990c27e8f6957 Mon Sep 17 00:00:00 2001 From: Hiroshi DOYU Date: Wed, 2 Sep 2009 20:06:38 +0530 Subject: [PATCH 5/10] omap mailbox: remove disable_/enable_mbox_irq in isr No need to handle it in isr, since irq won't happen during isr. Signed-off-by: Hiroshi DOYU --- arch/arm/plat-omap/mailbox.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index 6e713a7..8a6d087 100644 --- a/arch/arm/plat-omap/mailbox.c +++ b/arch/arm/plat-omap/mailbox.c @@ -209,8 +209,6 @@ static void __mbox_rx_interrupt(struct omap_mbox *mbox) mbox_msg_t msg; struct request_queue *q = mbox->rxq->queue; - disable_mbox_irq(mbox, IRQ_RX); - while (!mbox_fifo_empty(mbox)) { rq = blk_get_request(q, WRITE, GFP_ATOMIC); if (unlikely(!rq)) @@ -226,7 +224,6 @@ static void __mbox_rx_interrupt(struct omap_mbox *mbox) /* no more messages in the fifo. clear IRQ source. */ ack_mbox_irq(mbox, IRQ_RX); - enable_mbox_irq(mbox, IRQ_RX); nomem: schedule_work(&mbox->rxq->work); }