From patchwork Tue Sep 11 05:36:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Afzal Mohammed X-Patchwork-Id: 1435271 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 84E3C3FC33 for ; Tue, 11 Sep 2012 05:36:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751824Ab2IKFgO (ORCPT ); Tue, 11 Sep 2012 01:36:14 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:32854 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927Ab2IKFgN (ORCPT ); Tue, 11 Sep 2012 01:36:13 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id q8B5a5G0025526; Tue, 11 Sep 2012 00:36:06 -0500 Received: from DBDE70.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id q8B5a2KC005118; Tue, 11 Sep 2012 11:06:02 +0530 (IST) Received: from DBDE01.ent.ti.com ([fe80::d5df:c4b5:9919:4e10]) by DBDE70.ent.ti.com ([fe80::2141:513f:409:315a%21]) with mapi id 14.01.0323.003; Tue, 11 Sep 2012 11:06:02 +0530 From: "Mohammed, Afzal" To: Tony Lindgren , Artem Bityutskiy CC: "artem.bityutskiy@linux.intel.com" , "linux-omap@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "ivan.djelic@parrot.com" Subject: RE: [PATCH v3 10/10] mtd: nand: omap2: use gpmc provided irqs Thread-Topic: [PATCH v3 10/10] mtd: nand: omap2: use gpmc provided irqs Thread-Index: AQHNdwpF+1c02IAOZUS1grXsaSqRZ5dqJOIAgAhjLoCAEZM5AIAAr+bw Date: Tue, 11 Sep 2012 05:36:00 +0000 Message-ID: References: <1345895326.1815.4.camel@kyv> <20120830195349.GW1303@atomide.com> <20120911001710.GD1303@atomide.com> In-Reply-To: <20120911001710.GD1303@atomide.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tony, On Tue, Sep 11, 2012 at 05:47:10, Tony Lindgren wrote: > FYI, looks like a new warning got introduced, so I've > committed the following trivial patch on top of this series. I was not careful enough, sorry. Thanks for fixing it. Another hunk as follows would also be required for error path even though compiler didn't complain. Not sure whether you can fixup or I should post as a separate patch. As an aside, there was compiler warning before this series, but I didn't dare to touch it, so a warning was seen but thought it was due to the earlier one. And now Arnd has fixed the original warning. Regards Afzal > From: Tony Lindgren > Date: Mon, 10 Sep 2012 17:14:13 -0700 > Subject: [PATCH] mtd: nand omap2: Fix uninitialized err warning > > Commit bd4156fd (mtd: nand: omap2: use gpmc provided irqs) > introduced a new warning: > > drivers/mtd/nand/omap2.c: In function ‘omap_nand_probe’: > drivers/mtd/nand/omap2.c:1267: warning: ‘err’ may be used uninitialized in this function > > Signed-off-by: Tony Lindgren > > --- a/drivers/mtd/nand/omap2.c > +++ b/drivers/mtd/nand/omap2.c > @@ -1389,6 +1389,7 @@ static int __devinit omap_nand_probe(struct platform_device *pdev) > info->gpmc_irq_fifo = platform_get_irq(pdev, 0); > if (info->gpmc_irq_fifo <= 0) { > dev_err(&pdev->dev, "error getting fifo irq\n"); > + err = -ENODEV; > goto out_release_mem_region; > } > err = request_irq(info->gpmc_irq_fifo, omap_nand_irq, > diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 337cf0a..27293e3 100644 --- a/drivers/mtd/nand/omap2.c +++ b/drivers/mtd/nand/omap2.c @@ -1404,6 +1404,7 @@ static int __devinit omap_nand_probe(struct platform_device *pdev) info->gpmc_irq_count = platform_get_irq(pdev, 1); if (info->gpmc_irq_count <= 0) { dev_err(&pdev->dev, "error getting count irq\n"); + err = -ENODEV; goto out_release_mem_region; } err = request_irq(info->gpmc_irq_count, omap_nand_irq,