From patchwork Mon Jun 24 08:13:45 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Afzal Mohammed X-Patchwork-Id: 2769081 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 221DDC0AB1 for ; Mon, 24 Jun 2013 08:14:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B21F620124 for ; Mon, 24 Jun 2013 08:14:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 684D020122 for ; Mon, 24 Jun 2013 08:14:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753130Ab3FXIOS (ORCPT ); Mon, 24 Jun 2013 04:14:18 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:59649 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753064Ab3FXIOQ convert rfc822-to-8bit (ORCPT ); Mon, 24 Jun 2013 04:14:16 -0400 Received: from dbdlxv05.itg.ti.com ([172.24.171.60]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id r5O8DoPI032131; Mon, 24 Jun 2013 03:13:51 -0500 Received: from DBDE72.ent.ti.com (dbde72.ent.ti.com [172.24.171.97]) by dbdlxv05.itg.ti.com (8.14.3/8.13.8) with ESMTP id r5O8Dk4D003616; Mon, 24 Jun 2013 03:13:47 -0500 Received: from DBDE04.ent.ti.com ([fe80::21ac:d9f:f810:c8e7]) by DBDE72.ent.ti.com ([fe80::bd56:32bf:87fd:2763%27]) with mapi id 14.02.0342.003; Mon, 24 Jun 2013 16:13:46 +0800 From: "Mohammed, Afzal" To: Arnd Bergmann , Tony Lindgren CC: "Kishore, Ankur" , Linux OMAP List , Linux ARM Kernel List Subject: RE: [PATCH] ARM: omap: make am43xx build with SMP enabled Thread-Topic: [PATCH] ARM: omap: make am43xx build with SMP enabled Thread-Index: AQHObtZC646+d22VTUWCipRrmx3l6JlEe1gw Date: Mon, 24 Jun 2013 08:13:45 +0000 Message-ID: References: <201306220122.47786.arnd@arndb.de> In-Reply-To: <201306220122.47786.arnd@arndb.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Arnd, Tony, On Sat, Jun 22, 2013 at 04:52:47, Arnd Bergmann wrote: > With am43xx enabled, omap4 and omap5 disabled and SMP on, I get these > build errors: Getting AM43x only build with OMAP4/5 disabled was really difficult with original series itself, I thought finally had got a right Makefile change handling SMP combinations too, but still :(, my brain was not big enough to think of multiplatform case :) Thanks Arnd for the patch. > arch/arm/mach-omap2/built-in.o: In function `scu_gp_set': > :(.text+0x7858): undefined reference to `omap4_get_scu_base' > arch/arm/mach-omap2/built-in.o: In function `scu_gp_clear': > :(.text+0x793c): undefined reference to `omap4_get_scu_base' > arch/arm/mach-omap2/built-in.o: In function `omap4_cpu_die': > :(.ref.text+0x44): undefined reference to `omap4_hotplug_cpu' > > The easiest way to work around that is to turn on the missing > functions, even though we know they won't be used on am43xx, > which is single-CPU. This change was giving errors mainly due to unavailable omap4 prcm functions required by "omap-mpuss-lowpower.c" How about the below patch - we don't need to include additional files with it, or something wrong with it ? Regards Afzal ---8<------ From: Afzal Mohammed Date: Mon, 24 Jun 2013 12:41:05 +0530 Subject: [PATCH] ARM: OMAP2+: AM43x: resolve SMP related build error If AM43x and SMP is selected, OMAP4 & OMAP5 deselected, build error as follows, arch/arm/mach-omap2/built-in.o: In function `scu_gp_set': arch/arm/mach-omap2/sleep44xx.S:131: undefined reference to `omap4_get_scu_base' arch/arm/mach-omap2/sleep44xx.S:132: undefined reference to `scu_power_mode' arch/arm/mach-omap2/built-in.o: In function `scu_gp_clear': arch/arm/mach-omap2/sleep44xx.S:227: undefined reference to `omap4_get_scu_base' arch/arm/mach-omap2/sleep44xx.S:229: undefined reference to `scu_power_mode' Resolve it by building sleep44xx.S only for OMAP4 & OMAP5. Signed-off-by: Afzal Mohammed Acked-by: Tony Lindgren --- arch/arm/mach-omap2/Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index 0520dc4..a6c4187 100644 --- a/arch/arm/mach-omap2/Makefile +++ b/arch/arm/mach-omap2/Makefile @@ -35,8 +35,9 @@ obj-$(CONFIG_SOC_HAS_OMAP2_SDRC) += sdrc.o smp-$(CONFIG_SMP) += omap-smp.o omap-headsmp.o smp-$(CONFIG_HOTPLUG_CPU) += omap-hotplug.o -omap-4-5-common = omap4-common.o omap-wakeupgen.o \ - sleep44xx.o +omap-4-5-common = omap4-common.o omap-wakeupgen.o +obj-$(CONFIG_ARCH_OMAP4) += sleep44xx.o +obj-$(CONFIG_SOC_OMAP5) += sleep44xx.o obj-$(CONFIG_ARCH_OMAP4) += $(omap-4-5-common) $(smp-y) obj-$(CONFIG_SOC_OMAP5) += $(omap-4-5-common) $(smp-y) obj-$(CONFIG_SOC_AM43XX) += $(omap-4-5-common)