From patchwork Wed Jun 20 16:37:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Belisko Marek X-Patchwork-Id: 10477939 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 632EC60383 for ; Wed, 20 Jun 2018 16:37:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5106C28CAC for ; Wed, 20 Jun 2018 16:37:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 453F428EC2; Wed, 20 Jun 2018 16:37:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A7DA028CAC for ; Wed, 20 Jun 2018 16:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754162AbeFTQhU (ORCPT ); Wed, 20 Jun 2018 12:37:20 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:37783 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754144AbeFTQhT (ORCPT ); Wed, 20 Jun 2018 12:37:19 -0400 Received: by mail-wr0-f195.google.com with SMTP id k6-v6so188025wrp.4; Wed, 20 Jun 2018 09:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=heUlefXVeVr7ZSpoHl63kOfpk0kzmwVF3vQ9Cuq9Wdw=; b=ltWH/oILqD0OP4lcIyPu+qCFXUUVJkj/HwrR4V/x8vyPLaHQk3T93jEuu1qNrHo9zq SNC3m91D2KYG7AR4JjwCjONVaGxUVR+TyD8clDv8MadeKuuksA4BDPyTm90sZ0x2smof yNJIDN/oQLd/NmdnLKZxlR6M+uq3tk1h6Z0sqYhjqlLW5dAyCkX2JGBrFK+crJbvnTCE PwcERJ58KXgwT5XPxpHaZbo3UJmp47AIgNCb+MKzUhtjSnhjc5Ogn0Mtlt2vUI7oxDyy iy1mGpcn8ca9w06PN8mAQkLzYFjDgeRWAod3rLc6MDG/QWwRZ52qcxr5vhBJWxXVnSnr Zo5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=heUlefXVeVr7ZSpoHl63kOfpk0kzmwVF3vQ9Cuq9Wdw=; b=V9Ac9AWGKZNJ5JOGoqvlfPdX91OZHjP/FWwIi6NRRJ2R6YL7yHE8HP5WZhwatW+iJP TQ2lGpDh1k/UsBJUeJKUSF6q37yxafWn0yWIWGqKnLleN8JaVAM23FcMEWkS1MWXDNTh wlP8iaFt3m1NMUis+tmyMfCQo3zFqIiR1WoYp/cjc+W2b3YWqYHZTU8A1F4AvpdgEp2e Va+hPz9wVs84bGFbmJcxCQVrW67DbP0bfkSCpJmo1G071F+RfwLxzOmd203Xzl9hkWsD SAl9wvKmbrG035xwL3vnpLwPcV2HRjFAtlL5Qo3oPWfGQZphFHxQ1XOMfOXZ3hMZdoVp in+Q== X-Gm-Message-State: APt69E2d8CDNRU4rkO67ZW12k4/VBB8YoRC6LI3YPAuL3xGxCicbjFgw KDHeN9ZRCcySk4kUGHcLIFth6uz8bis9P1u/X6G/ow== X-Google-Smtp-Source: ADUXVKKjWGT4RL3b5sBwy33KEXbo6s0P7AGE4G3QHWU6qU8IQcENqDYTjetR1/zRguR40lzuIL4KT+MtPzAylmlFgmY= X-Received: by 2002:adf:9525:: with SMTP id 34-v6mr17422968wrs.99.1529512637825; Wed, 20 Jun 2018 09:37:17 -0700 (PDT) MIME-Version: 1.0 From: Belisko Marek Date: Wed, 20 Jun 2018 18:37:06 +0200 Message-ID: Subject: omap5 fixing palmas IRQ_TYPE_NONE warning leads to gpadc timeouts To: LKML , linux-omap@vger.kernel.org Cc: "Dr. H. Nikolaus Schaller" , Tony Lindgren Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, I'm trying to fix warning (for omap5 board) produced by recent change to avoid using IRQ_TYPE_NONE like: [ 1.818666] WARNING: CPU: 1 PID: 778 at drivers/irqchip/irq-gic.c:1016 gic_irq_domain_translate+0x78/0x100 [ 1.828839] Modules linked in: I did look to other commit which did update and without deep knowledge I just simply do this small change: and it looks board boots fine. Only issue is that gpadc driver is not working (at least not getting interrupts at all ADC fails with timeout). I did look to gpadc driver and driver is not using interrupts defined in dts but request interrupt directly from palmas mfd module. Any ideas what needs to be changed to have gpadc again working with mentioned patch? I tried to use also IRQ_TYPE_LOW but in this case board cannot mount rootfs so I was thinking this is not way to go. Thanks for any hints. BR, marek diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi index 218892b..ab2df8c 100644 --- a/arch/arm/boot/dts/omap5-board-common.dtsi +++ b/arch/arm/boot/dts/omap5-board-common.dtsi @@ -393,7 +393,7 @@ palmas: palmas@48 { compatible = "ti,palmas"; - interrupts = ; /* IRQ_SYS_1N */ + interrupts = ; /* IRQ_SYS_1N */ reg = <0x48>; interrupt-controller; #interrupt-cells = <2>;