From patchwork Sun Oct 27 13:26:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 3099371 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 8F3259F431 for ; Sun, 27 Oct 2013 13:26:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8F38E20259 for ; Sun, 27 Oct 2013 13:26:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9775B20250 for ; Sun, 27 Oct 2013 13:26:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754036Ab3J0N0x (ORCPT ); Sun, 27 Oct 2013 09:26:53 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:33668 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753995Ab3J0N0w (ORCPT ); Sun, 27 Oct 2013 09:26:52 -0400 Received: by mail-ie0-f182.google.com with SMTP id as1so9690551iec.13 for ; Sun, 27 Oct 2013 06:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=zu9Oq35UdGpIkiOjcgQ9pQMiKChRbBjgPDBJeIMONqU=; b=E0eJMrpJnyYI2VTZ1LBLNv4huGFGjMwzySeM8EAOZOoIJ8BpLc3oaTM8sX1piIL5jI yVcSpmeygK4FOEDl1HiwQGZFCyhDoiH/1ER9JXyX67Rf75lE5FkiSm18q5dScs3SFFLR Qe5Xgjg3uiCcZQLs1Pgv5z9vlIIuwBUc8m8KRV+a9y1y1sQpvrilvV9gwoe/lDu8kvKW iOTnzQcabZcVlGTns6MQU4ytZaG28R5CFH5WRicfIK+foBX7eysLHuKZpGCnQYm9IuJM tYOzwGfib702jk3dd4yxtnDm6jUoZMdbv2yRT35627ffE/Aoysd/YJMOXotOqCMP7Onp 6qtQ== X-Received: by 10.50.67.46 with SMTP id k14mr5294577igt.16.1382880411755; Sun, 27 Oct 2013 06:26:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.98.98 with HTTP; Sun, 27 Oct 2013 06:26:31 -0700 (PDT) In-Reply-To: <51ECFDFD.60102@ti.com> References: <20130517191304.468.73487.stgit@localhost> <20130517191751.468.89202.stgit@localhost> <20130520095447.GR21614@n2100.arm.linux.org.uk> <20130706131057.GU21614@n2100.arm.linux.org.uk> <20130706133627.GV21614@n2100.arm.linux.org.uk> <20130708093410.GT5523@atomide.com> <20130708142103.GX21614@n2100.arm.linux.org.uk> <51ECFDFD.60102@ti.com> From: Javier Martinez Canillas Date: Sun, 27 Oct 2013 14:26:31 +0100 Message-ID: Subject: Re: [PATCH 1/6] ARM: OMAP2+: Remove board-4430sdp.c To: Tomi Valkeinen , Enric Balletbo Serra Cc: Russell King - ARM Linux , Tony Lindgren , arm@kernel.org, "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Tomi, On Mon, Jul 22, 2013 at 11:40 AM, Tomi Valkeinen wrote: > On 08/07/13 17:21, Russell King - ARM Linux wrote: > >> Also looks like the nonfunctional video stuff is even more nonfunctional >> than usual: >> >> omapdss DSI error: can't get VDDS_DSI regulator >> omapdss HDMI error: can't get VDDA_HDMI_DAC regulator I have the same issue when trying to get VDI output working on a IGEPv2 board. > > Those should be followed by "...requests probe deferral", and the driver > is probed again later. > When booting with DT the omapfb's probe is deferred several times but it always fails on dpi_connect() due not being able to get the VDDS_DSI regulator: [ 3.186035] OMAPFB: omapfb_probe [ 3.190704] omapdss DPI error: can't get VDDS_DSI regulator [ 3.196594] omapfb omapfb: failed to connect default display [ 3.202667] omapfb omapfb: failed to init overlay connections [ 3.208892] OMAPFB: free_resources [ 3.212493] OMAPFB: free all fbmem [ 3.216735] omapfb omapfb: failed to setup omapfb [ 3.221832] platform omapfb: Driver omapfb requests probe deferral [ 3.231689] OMAPFB: omapfb_probe [ 3.236175] omapdss DPI error: can't get VDDS_DSI regulator [ 3.242248] omapfb omapfb: failed to connect default display [ 3.248291] omapfb omapfb: failed to init overlay connections [ 3.254394] OMAPFB: free_resources [ 3.258026] OMAPFB: free all fbmem [ 3.262268] omapfb omapfb: failed to setup omapfb [ 3.267303] platform omapfb: Driver omapfb requests probe deferral My complete boot log is [1] I tracked down to dpi_init_regulator in drivers/video/omap2/dss/dpi.c static int dpi_init_regulator(void) { .... vdds_dsi = devm_regulator_get(&dpi.pdev->dev, "vdds_dsi"); if (IS_ERR(vdds_dsi)) { DSSERR("can't get VDDS_DSI regulator\n"); return PTR_ERR(vdds_dsi); } .... } So I tried adding this to my DT with no luck. Now what you said does indeed happen when booting with the legacy board file. omapfb fails the first time with "can't get VDDS_DSI regulator" but the driver is probed again and it succeeds. I tried to spot a difference but didn't find it... > The log > http://www.arm.linux.org.uk/developer/build/result.php?type=boot&idx=946 > shows "taal display2: panel revision e3.83.7d" which hints that the > panel (and DSS) was initialized properly. > > Those error prints should probably be tuned down a bit now that the > driver uses probe deferral. > > Tomi > > fwiw, my wip branch is [2]: Javier Martinez Canillas (3): ARM: dts: omap3-igep0020: Add pinmux setup for i2c devices ARM: dts: omap3-igep0020: Add pinmuxig for DVI output ARM: OMAP: dss-common: change IGEP's DVI DDC i2c bus Any hints will be highly appreciated. Thanks a lot and best regards, Javier [1]: http://fpaste.org/49736/79384138/raw/ [2]: https://github.com/martinezjavier/linux/commits/igep-video-wip --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts index 17a6fc1..eaae935 100644 --- a/arch/arm/boot/dts/omap3-igep0020.dts +++ b/arch/arm/boot/dts/omap3-igep0020.dts @@ -256,3 +256,8 @@ &usbhsehci { phys = <&hsusb1_phy>; }; + +&vpll2 { + supply-dev = "omapdss_dpi.0"; + supply = "vdds_dsi"; +};