From patchwork Tue Jun 6 14:33:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yegor Yefremov X-Patchwork-Id: 9768973 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4F7F860364 for ; Tue, 6 Jun 2017 14:33:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3922C2582C for ; Tue, 6 Jun 2017 14:33:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2B39822B27; Tue, 6 Jun 2017 14:33:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 66D2F22B27 for ; Tue, 6 Jun 2017 14:33:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751435AbdFFOdr (ORCPT ); Tue, 6 Jun 2017 10:33:47 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:36401 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbdFFOdq (ORCPT ); Tue, 6 Jun 2017 10:33:46 -0400 Received: by mail-wr0-f196.google.com with SMTP id e23so9305989wre.3; Tue, 06 Jun 2017 07:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qc1KE6q87fOJWSECWgVXp6q07BIEKKUlaU5kJW/4KK4=; b=I4Qx+sifvvbMv4MEDUOtc8o4gsICE0J01UfUr/2ulrJf/ENWtA9RDbQjF25YKL0OKL 2vfTj3lDjSA3vBNTfxTm5scDfrIHOFLtuRhNnsBOmgS6SAGopVA4fBoxVxuIfI3aA07o DqdfwG/sbiXMMadFEuWP8IYp2EAynGENz/kMsCpF1tYEtidR5v7NBkv9Mw5dWxpnlCM9 WU43s8SvCenQ2GHQCCiPdK/PZ72flyd3JuB+O2oMD3mgyjiIdr6bfAIel82Y7MIomDSv zjNspYQREr/pS+7W9sZ+6P+VBBEXvQ3TXH9bLhU/M9uycirVTTDlUoa8ZL/aTAtieEID wN4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qc1KE6q87fOJWSECWgVXp6q07BIEKKUlaU5kJW/4KK4=; b=m7V09L0AFE2syEC3eytbWkw7ZyjmnKv7BiLkHG1+zsxM6ubFsg1pIQO4p+9sFF3BRz dDmBeuPdvh1uYRxxsb+PrtaQDBRNfbs/tSO4kyoawSTwcoZNGouofVi6Ww2yoF/d+Thz dMq2WYZGtn1ZxMvAqSVafeUMTgXAJ23twVTuMNnIC1A/Ga16HtgaeKFEEp66XfzYgdr/ QHA7rGGaZIqOLvk1NDYe4V5LgFtPpUlMz18wMkeQjIEnfecu9ubFyQ97DBVlsb6gEBaw gR4CNiBXI4bml0ENmYUIrfwgEKfVy41aWJilLo6EZ/ROKyk/kpbtNuX6kMqKqu1yqhJn lUjg== X-Gm-Message-State: AODbwcDcdF/was9+dofGdPDrjfyLSqhJ5FjMu3Ue5F9OI/t6hsP5jNMp P6ycRenEjZtGNiCQStHrnJZq/DLm4Q== X-Received: by 10.223.165.4 with SMTP id i4mr16212014wrb.148.1496759624647; Tue, 06 Jun 2017 07:33:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.146.162 with HTTP; Tue, 6 Jun 2017 07:33:23 -0700 (PDT) In-Reply-To: References: <20170526180609.2699-1-uwe@kleine-koenig.org> <20170526180609.2699-2-uwe@kleine-koenig.org> <20170531171932.GH3730@atomide.com> From: Yegor Yefremov Date: Tue, 6 Jun 2017 16:33:23 +0200 Message-ID: Subject: Re: [PATCH RFC 2/5] ARM: dts: am335x-baltos: use IRQ_TYPE_* to specify irq flags To: Tony Lindgren Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Rob Herring , Frank Rowand , Arnd Bergmann , linux-arm-kernel , Marek Vasut , devicetree@vger.kernel.org, =?UTF-8?Q?Beno=C3=AEt_Cousson?= , "linux-omap@vger.kernel.org" Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, May 31, 2017 at 7:22 PM, Yegor Yefremov wrote: > Hi Uwe, Tony, > > On Wed, May 31, 2017 at 7:19 PM, Tony Lindgren wrote: >> * Uwe Kleine-König [170526 11:09]: >>> According to the binding documentation and the source code the omap-gpio >>> controller takes IRQ_TYPE_* as its flags values, not GPIO_ACTIVE_*. >>> >>> This patch uses the right variable type which yields the same result >>> when compiled. Note that this might be wrong and actually >>> IRQ_TYPE_LEVEL_LOW is intended by the dt author. >>> >>> Signed-off-by: Uwe Kleine-König >>> --- >>> Hello, >>> >>> can somebody with the hardware or it's documentation please check which >>> flag is the right one? >> >> I'll wait on this one until we have somebody test it. > > I'll look at it this week. This is what works for me (at least it doesn't produce "irq 88: nobody cared (try booting with the "irqpoll" option)"). As for tca6416 it is working with all possible settings (from IRQ_TYPE_EDGE_RISING till IRQ_TYPE_LEVEL_LOW). "cat /proc/interrupts" always shows Level type: 47: 5 44e07000.gpio 20 Level 1-0020 Yegor --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/am335x-baltos-ir3220.dts b/arch/arm/boot/dts/am335x-baltos-ir3220.dts index 1b215c4..944b095 100644 --- a/arch/arm/boot/dts/am335x-baltos-ir3220.dts +++ b/arch/arm/boot/dts/am335x-baltos-ir3220.dts @@ -85,7 +85,7 @@ gpio-controller; #gpio-cells = <2>; interrupt-parent = <&gpio0>; - interrupts = <20 IRQ_TYPE_EDGE_RISING>; + interrupts = <20 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&tca6416_pins>; }; diff --git a/arch/arm/boot/dts/am335x-baltos-ir5221.dts b/arch/arm/boot/dts/am335x-baltos-ir5221.dts index 832ead8..ae5692b 100644 --- a/arch/arm/boot/dts/am335x-baltos-ir5221.dts +++ b/arch/arm/boot/dts/am335x-baltos-ir5221.dts @@ -94,7 +94,7 @@ gpio-controller; #gpio-cells = <2>; interrupt-parent = <&gpio0>; - interrupts = <20 IRQ_TYPE_EDGE_RISING>; + interrupts = <20 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&tca6416_pins>; }; diff --git a/arch/arm/boot/dts/am335x-baltos.dtsi b/arch/arm/boot/dts/am335x-baltos.dtsi index e3234d4..863942d 100644 --- a/arch/arm/boot/dts/am335x-baltos.dtsi +++ b/arch/arm/boot/dts/am335x-baltos.dtsi @@ -249,7 +249,7 @@ gpio-controller; #gpio-cells = <2>; interrupt-parent = <&gpio1>; - interrupts = <28 IRQ_TYPE_EDGE_RISING>; + interrupts = <28 IRQ_TYPE_EDGE_FALLING>; pinctrl-names = "default"; pinctrl-0 = <&tps65910_pins>; };