From patchwork Thu Aug 11 08:07:27 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ohad Ben Cohen X-Patchwork-Id: 1056072 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p7B87qgu001012 for ; Thu, 11 Aug 2011 08:07:52 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752950Ab1HKIHv (ORCPT ); Thu, 11 Aug 2011 04:07:51 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:65450 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821Ab1HKIHs convert rfc822-to-8bit (ORCPT ); Thu, 11 Aug 2011 04:07:48 -0400 Received: by wwf5 with SMTP id 5so1785481wwf.1 for ; Thu, 11 Aug 2011 01:07:47 -0700 (PDT) Received: by 10.216.24.30 with SMTP id w30mr1483212wew.68.1313050067093; Thu, 11 Aug 2011 01:07:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.28.149 with HTTP; Thu, 11 Aug 2011 01:07:27 -0700 (PDT) X-Originating-IP: [46.116.66.235] In-Reply-To: <1312889168.2407.148.camel@cumari> References: <1307356643.23002.413.camel@cumari> <20110606104417.GP18731@legolas.emea.dhcp.ti.com> <20110606110218.GS18731@legolas.emea.dhcp.ti.com> <1307358348.23002.419.camel@cumari> <1312889168.2407.148.camel@cumari> From: Ohad Ben-Cohen Date: Thu, 11 Aug 2011 11:07:27 +0300 Message-ID: Subject: Re: Oops on ehci_hcd when booting 3.0.0-rc2 on panda To: Luciano Coelho , Paul Walmsley , "Cousson, Benoit" , Rajendra Nayak Cc: balbi@ti.com, sameo@linux.intel.com, linux-omap@vger.kernel.org, linux-usb@vger.kernel.org, Keshava Munegowda , Kevin Hilman Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 11 Aug 2011 08:07:53 +0000 (UTC) + Paul, Benoit, Rajendra On Tue, Aug 9, 2011 at 2:26 PM, Luciano Coelho wrote: > I'm again getting a very similar oops with 3.1-rc1 on my pandaboard: > > [    2.054351] usbcore: registered new interface driver cdc_ncm > [    2.061431] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver > [    2.068664] Unhandled fault: imprecise external abort (0x1406) at 0x00000000 > [    2.076110] Internal error: : 1406 [#1] SMP > [    2.080505] Modules linked in: > [    2.083709] CPU: 0    Not tainted  (3.1.0-rc1-wl+ #283) > [    2.089233] PC is at omap_usbhs_enable+0x148/0x590 > [    2.094299] LR is at trace_hardirqs_off+0x14/0x18 ... > [    2.310150] [] (omap_usbhs_enable+0x148/0x590) from [] (ehci_hcd_omap_probe+0x1b4/0x568) > [    2.320526] [] (ehci_hcd_omap_probe+0x1b4/0x568) from [] (platform_drv_probe+0x24/0x28) > [    2.330780] [] (platform_drv_probe+0x24/0x28) from [] (driver_probe_device+0x158/0x27c) > [    2.341033] [] (driver_probe_device+0x158/0x27c) from [] (__driver_attach+0x78/0x9c) > [    2.351043] [] (__driver_attach+0x78/0x9c) from [] (bus_for_each_dev+0x5c/0x8c) > [    2.360565] [] (bus_for_each_dev+0x5c/0x8c) from [] (driver_attach+0x28/0x30) > [    2.369903] [] (driver_attach+0x28/0x30) from [] (bus_add_driver+0xd8/0x260) > [    2.379180] [] (bus_add_driver+0xd8/0x260) from [] (driver_register+0xb8/0x144) > [    2.388702] [] (driver_register+0xb8/0x144) from [] (platform_driver_register+0x54/0x68) > [    2.399047] [] (platform_driver_register+0x54/0x68) from [] (ehci_hcd_init+0xa8/0xfc) > [    2.409149] [] (ehci_hcd_init+0xa8/0xfc) from [] (do_one_initcall+0xa8/0x17c) > [    2.418487] [] (do_one_initcall+0xa8/0x17c) from [] (kernel_init+0x88/0x134) > [    2.427764] [] (kernel_init+0x88/0x134) from [] (kernel_thread_exit+0x0/0x8) I get this too. > Any clues? Reverting 665d001338b494d6d62810aa99b4c0fa1a0884b9 "OMAP2+: hwmod: Follow the recommended PRCM module enable sequence" fixes this for me. More specifically, this hunk alone seems to do the trick: I'm not suggesting this is anyway near a real fix, but hopefully it will help pin-point the problem (clock44xx_data.c changes ?). --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44x index 2af0e3f..12d22a8 100644 --- a/arch/arm/mach-omap2/clock44xx_data.c +++ b/arch/arm/mach-omap2/clock44xx_data.c @@ -3379,7 +3379,6 @@ int __init omap4xxx_clk_init(void) } clk_init(&omap2_clk_functions); - omap2_clk_disable_clkdm_control(); for (c = omap44xx_clks; c < omap44xx_clks + ARRAY_SIZE(omap44xx_clks); c++)