From patchwork Thu Jul 26 21:09:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juha Kuikka X-Patchwork-Id: 1245601 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id C3B51E009B for ; Thu, 26 Jul 2012 21:09:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752712Ab2GZVJg (ORCPT ); Thu, 26 Jul 2012 17:09:36 -0400 Received: from mail-yw0-f46.google.com ([209.85.213.46]:62597 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752247Ab2GZVJe (ORCPT ); Thu, 26 Jul 2012 17:09:34 -0400 Received: by yhmm54 with SMTP id m54so2496488yhm.19 for ; Thu, 26 Jul 2012 14:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ELGKwFq5IuPCw9GTGI6QQboOyCZiRv7Ok7Tanj4aUDQ=; b=tbeD7rY7dwpUNOJX3klu6vPffkiwSRtaioC5Vwj9pI+1V935QqLUUSlwyL3HD0VYOv vKgi3cIzG9HxBj+Ni+q00groeQ6WNWD4Rmu3Z0LqAjTDrinB5Pxtf8q9/iqC/747xKDD 9HnJALPrB6JAegzEp7OsgPgnNlx1qD7TPwco/QnsfFL4GBL+JoRNEh2HgxV3AdRxNoEW yxZUtOF718jz6MI6v1EIcRwMN2vUps0iOz/ZC1wrJp7MO48JlEenQmTkv+Kwv/duHV/L a+VaNn+zbrECyCvw3pTjM42tsv/Pmbi7+Dl26k2XZhu+L0phQ8p8pzLqcmJJInLlI9gS dgfQ== MIME-Version: 1.0 Received: by 10.42.31.5 with SMTP id x5mr91895icc.40.1343336973720; Thu, 26 Jul 2012 14:09:33 -0700 (PDT) Received: by 10.64.136.38 with HTTP; Thu, 26 Jul 2012 14:09:33 -0700 (PDT) In-Reply-To: <20120718172654.GA27904@animalcreek.com> References: <20120717004010.GA6612@animalcreek.com> <20120718022035.GC18663@animalcreek.com> <20120718172654.GA27904@animalcreek.com> Date: Thu, 26 Jul 2012 14:09:33 -0700 Message-ID: Subject: Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC? From: Juha Kuikka To: "Mark A. Greer" Cc: Joe Woodward , Paul Walmsley , Kevin Hilman , linux-omap@vger.kernel.org Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org A thousand apologizes for double posting, some html sneaked into the first email and it got dropped by the list server. I am running on a gumstix with OMAP 3503 on it (name escapes me at the moment) and it has the same issue. Just applying Mark's patch on top of 55936cdfaaf11ac352b56bc58e42d6661e65ee13 (linux-omap) is not enough, I also need to set the OMAP3_HAS_IVA_REGS for the 3430 as well. Inlined patch: Here is with I see with this patch: /debug/pm_debug # echo mem > /sys/power/state [ 1058.657928] PM: Syncing filesystems ... done. [ 1058.669616] Freezing user space processes ... (elapsed 0.02 seconds) done. [ 1058.703094] Freezing remaining freezable tasks ... (elapsed 0.02 seconds) done. [ 1058.734252] Suspending console(s) (use no_console_suspend to debug) [ 1058.921936] PM: suspend of devices complete after 161.285 msecs [ 1058.938995] PM: late suspend of devices complete after 16.936 msecs [ 1058.963134] PM: noirq suspend of devices complete after 23.986 msecs [ 1060.013336] Successfully put all powerdomains to target state [ 1060.025726] PM: noirq resume of devices complete after 11.810 msecs [ 1060.042480] PM: early resume of devices complete after 10.437 msecs [ 1060.481353] PM: resume of devices complete after 438.415 msecs [ 1060.547912] Restarting tasks ... done. /debug/pm_debug # cat /debug/pm_debug/count usbhost_pwrdm (ON),OFF:0,RET:0,INA:0,ON:1,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0 sgx_pwrdm (OFF),OFF:1,RET:0,INA:0,ON:0,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0 core_pwrdm (ON),OFF:0,RET:1,INA:0,ON:2,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0,RET-MEMBANK2-OFF:0 per_pwrdm (ON),OFF:0,RET:1,INA:0,ON:2,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0 dss_pwrdm (ON),OFF:0,RET:0,INA:0,ON:1,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0 cam_pwrdm (RET),OFF:0,RET:1,INA:0,ON:1,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0 neon_pwrdm (ON),OFF:0,RET:710,INA:0,ON:711,RET-LOGIC-OFF:0 mpu_pwrdm (ON),OFF:0,RET:710,INA:0,ON:711,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0 iva2_pwrdm (RET),OFF:0,RET:1,INA:0,ON:1,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0,RET-MEMBANK2-OFF:0,RET-MEMBANK3-OFF:0,RET-MEMBANK4-OFF:0 usbhost_clkdm->usbhost_pwrdm (1) sgx_clkdm->sgx_pwrdm (0) per_clkdm->per_pwrdm (18) cam_clkdm->cam_pwrdm (0) dss_clkdm->dss_pwrdm (1) d2d_clkdm->core_pwrdm (0) iva2_clkdm->iva2_pwrdm (0) mpu_clkdm->mpu_pwrdm (0) core_l4_clkdm->core_pwrdm (24) core_l3_clkdm->core_pwrdm (4) neon_clkdm->neon_pwrdm (0) I see that the usbhost domain is still not hitting retention but for some reason it is not being complained about in suspend messages. I am running omap2plus_defconfig with CPUFREQ and CPUIDLE enabled, USB disabled. - Juha On Wed, Jul 18, 2012 at 10:26 AM, Mark A. Greer wrote: > > On Wed, Jul 18, 2012 at 11:06:34AM +0100, Joe Woodward wrote: > > From: "Mark A. Greer" > > > > How does this look? > > > > Subject: [PATCH] ARM: OMAP3: Add OMAP3_HAS_IVA_REGS feature > > > > > > It appears that the am3703 and possibly the am3715 SoCs > > > have an active IVA subsystem even though the CONTROL_IDCODE > > > register indicates that they don't. From experimentation, > > > it seems that the IVA still requires some registers to be > > > initialized even though we don't want it fully functional. > > > > > > To accomplish this, add a new feature (OMAP3_HAS_IVA_REGS) > > > that indicates that the IVA should be initialized but not > > > really used. > > > > > > Signed-off-by: Mark A. Greer > > > --- > > > Tested on a GUMSTIX Overo AirSTORM (AM3703-based), and that fixes the problem for me, thanks! > > Great! Thanks for testing, Joe. > > Paul, Kevin, any comments? > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --- Duck tape is like the force, it has a light side and a dark side and it holds the universe together. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c index 4072fbd..45d3eb4 100644 --- a/arch/arm/mach-omap2/id.c +++ b/arch/arm/mach-omap2/id.c @@ -244,7 +244,7 @@ void __init omap3xxx_check_features(void) if (cpu_is_omap3630()) omap_features |= OMAP3_HAS_192MHZ_CLK | OMAP3_HAS_IVA_REGS; if (cpu_is_omap3430() || cpu_is_omap3630()) - omap_features |= OMAP3_HAS_IO_WAKEUP; + omap_features |= OMAP3_HAS_IO_WAKEUP | OMAP3_HAS_IVA_REGS; if (cpu_is_omap3630() || omap_rev() == OMAP3430_REV_ES3_1 || omap_rev() == OMAP3430_REV_ES3_1_2) omap_features |= OMAP3_HAS_IO_CHAIN_CTRL;