From patchwork Fri Jun 10 11:37:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Fenkart X-Patchwork-Id: 9169551 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BF367604DB for ; Fri, 10 Jun 2016 11:37:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AFF4D26490 for ; Fri, 10 Jun 2016 11:37:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A4AEB28359; Fri, 10 Jun 2016 11:37:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A25C326490 for ; Fri, 10 Jun 2016 11:37:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753247AbcFJLhy (ORCPT ); Fri, 10 Jun 2016 07:37:54 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:34037 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752737AbcFJLhx (ORCPT ); Fri, 10 Jun 2016 07:37:53 -0400 Received: by mail-wm0-f50.google.com with SMTP id k184so2487344wme.1 for ; Fri, 10 Jun 2016 04:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=XdprzLUBumv72UU3fOLlVgwJdJslMo1PzB3XQYng7ms=; b=yvu3R3lomgYca6yuWtEGTVyQKMeUNolXfW2uNJ3apPsVGFlAHsR4y/nntjs/tTlA/6 faJaTHqsv8hkHZalPGYxuxeBZRWUs/w9ON6tXQkEw4Q47/WHpgO/wuj86oga33uLHjzK bGQ7ie/B+mznVUY2FbV7PiJ3W7YUDPjN8roq+Ttabd8FKLFYR7/ANOn2lPw1SNza+cOr l3gPZG/J7XjE1NLIjNBRrVQmJW/4O2+TF1dCATrMXc1NMZCUIGUpyVwSyPYTHIk6ParU lp14E2lRKBPZG9KXO6YhTiOEegWi/wMICwnnTElVUc371k2NUoEwhiSZmcM2wHnQntSD Cb0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=XdprzLUBumv72UU3fOLlVgwJdJslMo1PzB3XQYng7ms=; b=NlMWmXv56Q+fbTHS4Q0ofvLsgsXjxDRQFbvNlaJ68bFOn+/Rfahj7gR1nKHAee4iFC uG7RiJpCGmGwlv16NAFAT/3vLgbrsY1Dn7QUuxievtcp/690ZJzb/sSC5GeDS9T3l/Ws Tdsws9H1GuAILbF6r2jLabKhDu5EC//kNuf8pFBU45HA+BY6XNq9oD9jnET/9A4UZDyA FJfhNNDo4yHD/9v5WJYZ3sWLHZ709x7uE7lW7lJ4gDE6MXBnkrpA/GbLFLNvVXf+6MaC TRuJQoKOANZsKNx6MJSCwExg1ItC5G7mkdTYb7LUOfjsB3aShse7XZwBfrAQIEsUxjj4 e9Zg== X-Gm-Message-State: ALyK8tKy+29MFSAekYBgj0fgO1mqWAjW+bXooO0HrlgGnqIkhHTVjn8cnGB9tFzT2thvT8vmQooewofwQKa5Qw== X-Received: by 10.194.173.65 with SMTP id bi1mr1938071wjc.160.1465558671915; Fri, 10 Jun 2016 04:37:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.189.102 with HTTP; Fri, 10 Jun 2016 04:37:51 -0700 (PDT) In-Reply-To: References: <002701d1bdc0$3f9a91c0$becfb540$@inventeksys.com> <20160607060438.GE22406@atomide.com> <003101d1c1c6$7f234bc0$7d69e340$@inventeksys.com> <20160609064428.GI22406@atomide.com> <002901d1c271$8c5d9010$a518b030$@inventeksys.com> <20160610092859.GP22406@atomide.com> From: Andreas Fenkart Date: Fri, 10 Jun 2016 13:37:51 +0200 Message-ID: Subject: Re: Bringing up the BRCM43362 on Beaglebone Black To: Tony Lindgren Cc: Michael Eskowitz , linux-omap Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP me again, 2016-06-10 13:20 GMT+02:00 Andreas Fenkart : > >> The omap_hsmmc.c driver supports configuring two interrupts, and >> two named pinctrl states. See PINCTRL_STATE_IDLE in the driver. >> >> You need to define the dat1 GPIO mux mode as the PINCTRL_STATE_IDLE >> in the dts file, and add that as the second interrupt using the >> interrupts-extended binding. > > Actually it should work without this. The throughput would be lame > though, since it would fallback to polling mode. > > http://www.mjmwired.net/kernel/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt#61 just realized that am33xx.dtsi, declares the mmc ports to be compatible with "ti,omap4-hsmmc" mmc1: mmc@48060000 { compatible = "ti,omap4-hsmmc"; That way the omap_hsmmc driver will never emit a warning for missing pinctrl states, and NOT fallback to polling. That would explain the problems that Michael observed. This probably should be changed to: Guess this makes sense for all platforms based on am33xx and points people into the right direction quicker. /Andreas --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -357,7 +357,7 @@ }; mmc1: mmc@48060000 { - compatible = "ti,omap4-hsmmc"; + compatible = "ti,am33xx-hsmmc"; ti,hwmods = "mmc1"; ti,dual-volt; ti,needs-special-reset;