From patchwork Thu Sep 6 06:35:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shilimkar X-Patchwork-Id: 1412151 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id B4FD3DFFCF for ; Thu, 6 Sep 2012 06:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751520Ab2IFGgI (ORCPT ); Thu, 6 Sep 2012 02:36:08 -0400 Received: from na3sys009aog113.obsmtp.com ([74.125.149.209]:38414 "EHLO na3sys009aog113.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751325Ab2IFGgH (ORCPT ); Thu, 6 Sep 2012 02:36:07 -0400 Received: from mail-ob0-f198.google.com ([209.85.214.198]) (using TLSv1) by na3sys009aob113.postini.com ([74.125.148.12]) with SMTP ID DSNKUEhEVjZzmoJ+SP0UjK9oX9XhsYtS5BZo@postini.com; Wed, 05 Sep 2012 23:36:07 PDT Received: by obbwc20 with SMTP id wc20so4086665obb.1 for ; Wed, 05 Sep 2012 23:36:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=FqSp9pZGNnVfrLF/yKVNCMfHRMyHxxvzHzRDvWJFCLE=; b=kdGdTD/wlfvbhaiHx4MhOtrj3e0DaE/sosaf8vAK/6zjbvm4nv6kYCbhyd/HJNYgAG 3M0yHWK392avKRy701sBS23CisHA25pKjLbt3vQ6iG5K9CkzYCx5thuQTFco4aflcayX mIkMmPms71HAowWCAy9qQmm+A/OJ9wCAKo4REfmDqW8Km00GqasiDe2G07GIjgkYifE/ ZYoM5z0MEAmkN2jasokbU58x29Px1/jj1UhsxcVKbW75NLsBGch+bnVaHqDyNMXIclGL xpCKwkYTqC8OatOyUvzfDDW/BaBXHca5SbvF8QIfj5za0GJPaBZoPnNOO71LLxgTSXnH Qcgg== Received: by 10.50.191.165 with SMTP id gz5mr1011450igc.50.1346913366077; Wed, 05 Sep 2012 23:36:06 -0700 (PDT) Received: by 10.50.191.165 with SMTP id gz5mr1011439igc.50.1346913365862; Wed, 05 Sep 2012 23:36:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.65.85 with HTTP; Wed, 5 Sep 2012 23:35:45 -0700 (PDT) In-Reply-To: References: From: "Shilimkar, Santosh" Date: Thu, 6 Sep 2012 12:05:45 +0530 Message-ID: Subject: Re: [PATCH] ARM: OMAP4: wakeupgen: remove duplicate AUXCOREBOOT* read/write To: Paul Walmsley Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-Gm-Message-State: ALoCoQnKvt797c0UQVuk7oaAMYiVlA1edpvHIkMm7xY0TSZ3nk2R5qfzvIYKQAE0I1r/FbUT/rdnt5jCgbIDeStpzVhH1dwohH81pBLLJiB5/130ZQYlv2aJelMbN2+t6CtjNPvNGZeYODGl/4rATeUdwQFp6/XTp//vvaHAUn6AywNpp17FGEA= Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Thu, Sep 6, 2012 at 5:04 AM, Paul Walmsley wrote: > > The wakeupgen context-save code reads and stores the AUXCOREBOOT0 and > AUXCOREBOOT1 register contents twice. This seems like a waste of > time, so, remove the duplicates. > > Signed-off-by: Paul Walmsley > Cc: Santosh Shilimkar > --- Looks fine to me. Thanks Paul. Reviewed-by: Santosh Shilimkar ,santosh.shilimkar@ti.com> While reviewing your patch, i noticed a typo in the code. Since the patch fixes nearby code as the subject patch, I generated that patch on top of yours. Same is end of the email as well as attachment. The patch applies on top of your patch. Regards Santosh From 5fcd24e5782e502aa607b73de78be68b394f9639 Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar Date: Thu, 6 Sep 2012 11:51:34 +0530 Subject: [PATCH] ARM: OMAP4: wakeupgen: Fix the typo in AUXCOREBOOT register save The wakeupgen context-save code reads AUXCOREBOOT0 register instead of AUXCOREBOOT1 register contents while saving AUXCOREBOOT1. Fix the same. Signed-off-by: Santosh Shilimkar --- arch/arm/mach-omap2/omap-wakeupgen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/omap-wakeupgen.c b/arch/arm/mach-omap2/omap-wakeupgen.c index b55432d..567f672 100644 --- a/arch/arm/mach-omap2/omap-wakeupgen.c +++ b/arch/arm/mach-omap2/omap-wakeupgen.c @@ -229,7 +229,7 @@ static inline void omap4_irq_save_context(void) /* Save AuxBoot* registers */ val = __raw_readl(wakeupgen_base + OMAP_AUX_CORE_BOOT_0); __raw_writel(val, sar_base + AUXCOREBOOT0_OFFSET); - val = __raw_readl(wakeupgen_base + OMAP_AUX_CORE_BOOT_0); + val = __raw_readl(wakeupgen_base + OMAP_AUX_CORE_BOOT_1); __raw_writel(val, sar_base + AUXCOREBOOT1_OFFSET); /* Save SyncReq generation logic */