| Message ID | CAPgLHd--5Y4cq3ieoRSueg-i0boqRa4JqRPL7+cJ0UfesunjoQ@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sunday 21 October 2012 06:24 PM, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Add the missing unlock on the error handling path in function > hdmi_dump_regs(). > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Looks good to me; feel free to add: Reviewed-by: Sumit Semwal <sumit.semwal@ti.com> > --- > no test > --- > drivers/video/omap2/dss/hdmi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c > index a48a7dd..8c9b8b3 100644 > --- a/drivers/video/omap2/dss/hdmi.c > +++ b/drivers/video/omap2/dss/hdmi.c > @@ -644,8 +644,10 @@ static void hdmi_dump_regs(struct seq_file *s) > { > mutex_lock(&hdmi.lock); > > - if (hdmi_runtime_get()) > + if (hdmi_runtime_get()) { > + mutex_unlock(&hdmi.lock); > return; > + } > > hdmi.ip_data.ops->dump_wrapper(&hdmi.ip_data, s); > hdmi.ip_data.ops->dump_pll(&hdmi.ip_data, s); > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2012-10-21 15:54, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Add the missing unlock on the error handling path in function > hdmi_dump_regs(). > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > --- > no test > --- > drivers/video/omap2/dss/hdmi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c > index a48a7dd..8c9b8b3 100644 > --- a/drivers/video/omap2/dss/hdmi.c > +++ b/drivers/video/omap2/dss/hdmi.c > @@ -644,8 +644,10 @@ static void hdmi_dump_regs(struct seq_file *s) > { > mutex_lock(&hdmi.lock); > > - if (hdmi_runtime_get()) > + if (hdmi_runtime_get()) { > + mutex_unlock(&hdmi.lock); > return; > + } > > hdmi.ip_data.ops->dump_wrapper(&hdmi.ip_data, s); > hdmi.ip_data.ops->dump_pll(&hdmi.ip_data, s); > Thanks, applied to omapdss tree. Tomi
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c index a48a7dd..8c9b8b3 100644 --- a/drivers/video/omap2/dss/hdmi.c +++ b/drivers/video/omap2/dss/hdmi.c @@ -644,8 +644,10 @@ static void hdmi_dump_regs(struct seq_file *s) { mutex_lock(&hdmi.lock); - if (hdmi_runtime_get()) + if (hdmi_runtime_get()) { + mutex_unlock(&hdmi.lock); return; + } hdmi.ip_data.ops->dump_wrapper(&hdmi.ip_data, s); hdmi.ip_data.ops->dump_pll(&hdmi.ip_data, s);