From patchwork Thu May 9 02:06:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2542591 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 47B7BDF2E5 for ; Thu, 9 May 2013 02:06:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754274Ab3EICGX (ORCPT ); Wed, 8 May 2013 22:06:23 -0400 Received: from mail-bk0-f42.google.com ([209.85.214.42]:65334 "EHLO mail-bk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753353Ab3EICGW (ORCPT ); Wed, 8 May 2013 22:06:22 -0400 Received: by mail-bk0-f42.google.com with SMTP id j4so1219910bkw.15 for ; Wed, 08 May 2013 19:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to:cc :content-type; bh=6eOdyttSbd4OatoA7Ea6fr4uN0GKK639wRghJ/6mdpo=; b=0+YB7vr1m804XMn7bO1oZyvI7VHNr+xXhzQg9HIVk8MtdOL5VL67Xjg6hudJx3LjMU rPcN/1FB5oz8s7BYaXXvv4eHDg1gxpMRWipIMZDX3YzrbwSSy1lbv7BY5UjEEnxad8U2 WnLQ0CiWhHvEZZ3Sp+f7AyC2GNcKPUlOIrjg2wn3GJCFMNhASQSBbdgwz8DQbNTz0yDI sNll622BjusJKubj0OipTExcFq1yPMhKsbyEPaVT0fCTQzEM2rPQA4U5zsSiFg/7IG+z At0+2CQy1zRRG8U4SKsvEgk4awd8pXV7KD1NNbdtku97+YvDVVCulHp+EXnnW5plzvHh bx6g== MIME-Version: 1.0 X-Received: by 10.205.101.65 with SMTP id cz1mr2535488bkc.124.1368065180609; Wed, 08 May 2013 19:06:20 -0700 (PDT) Received: by 10.204.199.129 with HTTP; Wed, 8 May 2013 19:06:20 -0700 (PDT) Date: Thu, 9 May 2013 10:06:20 +0800 Message-ID: Subject: [PATCH] mmc: omap_hsmmc: fix error return code in omap_hsmmc_probe() From: Wei Yongjun To: balajitk@ti.com, cjb@laptop.org, grant.likely@linaro.org, rob.herring@calxeda.com Cc: yongjun_wei@trendmicro.com.cn, linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org From: Wei Yongjun Fix to return a negative error code in the init error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/mmc/host/omap_hsmmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 6e44025..32d3659 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -1948,7 +1948,8 @@ static int omap_hsmmc_probe(struct platform_device *pdev) } if (pdata->init != NULL) { - if (pdata->init(&pdev->dev) != 0) { + ret = pdata->init(&pdev->dev); + if (ret != 0) { dev_err(mmc_dev(host->mmc), "Unable to configure MMC IRQs\n"); goto err_irq_cd_init;