From patchwork Fri Jul 12 04:59:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2826801 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5C44AC0AB2 for ; Fri, 12 Jul 2013 05:00:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 72D232016D for ; Fri, 12 Jul 2013 05:00:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 892452013C for ; Fri, 12 Jul 2013 05:00:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751418Ab3GLE7o (ORCPT ); Fri, 12 Jul 2013 00:59:44 -0400 Received: from mail-bk0-f43.google.com ([209.85.214.43]:64473 "EHLO mail-bk0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951Ab3GLE7m (ORCPT ); Fri, 12 Jul 2013 00:59:42 -0400 Received: by mail-bk0-f43.google.com with SMTP id jm2so3613662bkc.2 for ; Thu, 11 Jul 2013 21:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=fygF22SVh/0AVLSNfTMd9DgCN9Is+qVjq5H+LhSdpLo=; b=EI9KuVOQo7xP2wcdzxMOwc9Jo0XmEQpinuhLgdojEmb7oMvmB59fsPgetwlnxvfdCS D8T8lz2F+aph/h4x9CgrjutBw3a7BcgxUyMbHWQSCPRTnYSEOhTGYqR5FpIEPpreWphH Fw+hMwcHyfoamjykcs5vgRXHMCJBlQxuO90o3MMyXB6d9tzeph3wdeTNfWwuJjgPSyJ0 KyM2LA6lrMjINaMrxavXMn8OU1c3LFlspoGHfbz1cJN/FqlbyjbruZAH4fOuVKtanYzC vMjaAN0nzguRLEuEfw8lwW47rDra2H8bQc5ePUrsoLnh5G1iFkytm8UW3B1SCeZd7fkf Pu/w== MIME-Version: 1.0 X-Received: by 10.204.229.7 with SMTP id jg7mr6128124bkb.58.1373605181017; Thu, 11 Jul 2013 21:59:41 -0700 (PDT) Received: by 10.205.122.72 with HTTP; Thu, 11 Jul 2013 21:59:40 -0700 (PDT) In-Reply-To: <877gh8nbpm.fsf@linaro.org> References: <20130626130641.GA26920@kahuna> <877gh8nbpm.fsf@linaro.org> Date: Fri, 12 Jul 2013 12:59:40 +0800 Message-ID: Subject: [PATCH RESEND] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe() From: Wei Yongjun To: khilman@linaro.org Cc: nm@ti.com, anton@enomsg.org, dwmw2@infradead.org, andrii.tseglytskyi@ti.com, jean.pihet@newoldbits.com, tony@atomide.com, yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-pm@vger.kernel.org Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun Acked-by: Nishanth Menon --- cc to linux-pm with Nishanth Menon's ACK --- drivers/power/avs/smartreflex.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c index db9973b..c26acfc 100644 --- a/drivers/power/avs/smartreflex.c +++ b/drivers/power/avs/smartreflex.c @@ -871,10 +871,8 @@ static int __init omap_sr_probe(struct platform_device *pdev) mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); sr_info->base = devm_ioremap_resource(&pdev->dev, mem); - if (IS_ERR(sr_info->base)) { - dev_err(&pdev->dev, "%s: ioremap fail\n", __func__); + if (IS_ERR(sr_info->base)) return PTR_ERR(sr_info->base); - } irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);