From patchwork Tue Jul 16 12:10:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2828099 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 8ADAE9F7D6 for ; Tue, 16 Jul 2013 12:10:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6D5DC201C6 for ; Tue, 16 Jul 2013 12:10:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B81A620177 for ; Tue, 16 Jul 2013 12:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932210Ab3GPMKs (ORCPT ); Tue, 16 Jul 2013 08:10:48 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:55497 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932162Ab3GPMKr (ORCPT ); Tue, 16 Jul 2013 08:10:47 -0400 Received: by mail-bk0-f46.google.com with SMTP id na10so226506bkb.5 for ; Tue, 16 Jul 2013 05:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=d6sU60d3bQhVg7oz6TboEj6EkTgs+jTb8zm9ILTyudI=; b=CswE17diCdnFtbs6iCBFgU7kpNuuL460/7HHzNvtB9UV4ztFdZ+eh80cjSQzGyVleF f/KcE84piG3vWLj5CtPJt+jwFt5Sza708EVJH1wTt14o2R3lxeif7gEDjvwrqh2fbS/k AK8Apv4bgGLagjm1CJMqE0CATE0QLIqxXMdsn5tabkpnmsGd1iEvhYh55ndrx33aW5Rc SUl0LYrE5LZr4yHJwyySJRXbWKIKAMm3LhLx9SBbnjxfIkOiwQ+QdGKLJXo34yTJsrVc yVET0lMdmuRh/sHTPIDe0XmwGITVz5xHC0DVPcft6NYzmqv5HAV+VY24ky85Iga+1KzV gIkA== MIME-Version: 1.0 X-Received: by 10.204.189.80 with SMTP id dd16mr226611bkb.126.1373976646276; Tue, 16 Jul 2013 05:10:46 -0700 (PDT) Received: by 10.205.122.72 with HTTP; Tue, 16 Jul 2013 05:10:46 -0700 (PDT) Date: Tue, 16 Jul 2013 20:10:46 +0800 Message-ID: Subject: [PATCH] ARM: OMAP: dma: fix error return code in omap_system_dma_probe() From: Wei Yongjun To: tony@atomide.com, linux@arm.linux.org.uk Cc: yongjun_wei@trendmicro.com.cn, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- arch/arm/plat-omap/dma.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c index 4d463ca..0376606 100644 --- a/arch/arm/plat-omap/dma.c +++ b/arch/arm/plat-omap/dma.c @@ -2083,6 +2083,7 @@ static int omap_system_dma_probe(struct platform_device *pdev) dma_irq = platform_get_irq_byname(pdev, irq_name); if (dma_irq < 0) { dev_err(&pdev->dev, "failed: request IRQ %d", dma_irq); + ret = dma_irq; goto exit_dma_lch_fail; } ret = setup_irq(dma_irq, &omap24xx_dma_irq);