From patchwork Sat Oct 12 06:11:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 3030841 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D764B9F1E1 for ; Sat, 12 Oct 2013 06:11:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0828920394 for ; Sat, 12 Oct 2013 06:11:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B2D820179 for ; Sat, 12 Oct 2013 06:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752856Ab3JLGLd (ORCPT ); Sat, 12 Oct 2013 02:11:33 -0400 Received: from mail-bk0-f48.google.com ([209.85.214.48]:43923 "EHLO mail-bk0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752690Ab3JLGLc (ORCPT ); Sat, 12 Oct 2013 02:11:32 -0400 Received: by mail-bk0-f48.google.com with SMTP id my13so1863413bkb.21 for ; Fri, 11 Oct 2013 23:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=KPN1k7M+afSOCnwTZ4K/MjnWBVKhZV+2eHpt0LE3WEQ=; b=A8MvbToAuF6gDIDcgdUDjiXe6KgcSdUUPBNatGq2G8xVSSJKJVaxZWi995uvCtng8m S/S/sxqzSHFkT791A5pdNiYCs7iI4kCI3qtvWOV8yqelHMysyIQs/bH7kVsS1z7GprT8 y+Tg148B+UgcVS5IkYcycQ0kGDPGKZq4Fn8f33n1juLY91p/pErFYMNY43/tCrA9Mq8d hRKAF+MJPwn0TnAxz53ROwfGHY3esxbaKtshxEQMW9O3DfI0hbaUmDXmJrucQMqxwEE8 lJwdMrNeEExxrek98ok6Myu3IGTcYeXat6GaV4l+Fc4cVmHuveCTkBE9eTcXZ5WK3nyS /G0A== MIME-Version: 1.0 X-Received: by 10.205.65.17 with SMTP id xk17mr20516741bkb.19.1381558291206; Fri, 11 Oct 2013 23:11:31 -0700 (PDT) Received: by 10.205.19.10 with HTTP; Fri, 11 Oct 2013 23:11:31 -0700 (PDT) Date: Sat, 12 Oct 2013 14:11:31 +0800 Message-ID: Subject: [PATCH -next] usb: phy: omap: remove redundant dev_err call in omap_control_usb_probe() From: Wei Yongjun To: balbi@ti.com, gregkh@linuxfoundation.org, grant.likely@linaro.org, rob.herring@calxeda.com Cc: yongjun_wei@trendmicro.com.cn, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/usb/phy/phy-omap-control.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/usb/phy/phy-omap-control.c b/drivers/usb/phy/phy-omap-control.c index 09c5ace..1321e3f 100644 --- a/drivers/usb/phy/phy-omap-control.c +++ b/drivers/usb/phy/phy-omap-control.c @@ -253,10 +253,8 @@ static int omap_control_usb_probe(struct platform_device *pdev) res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "power"); control_usb->power = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(control_usb->power)) { - dev_err(&pdev->dev, "Couldn't get power register\n"); + if (IS_ERR(control_usb->power)) return PTR_ERR(control_usb->power); - } } if (control_usb->type == OMAP_CTRL_TYPE_PIPE3) {