From patchwork Sat Oct 6 12:40:42 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell King X-Patchwork-Id: 1557291 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 33FDD3FD56 for ; Sat, 6 Oct 2012 12:40:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756048Ab2JFMkv (ORCPT ); Sat, 6 Oct 2012 08:40:51 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:47228 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755805Ab2JFMkv (ORCPT ); Sat, 6 Oct 2012 08:40:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=caramon; h=Date:Sender:Message-Id:Subject:Cc:To:From:References:In-Reply-To; bh=Z82oTam4DlqsrrgHbj9f5GjVzXig3u80a/62xgfTvB8=; b=ShrstjOdcsLoycjlbutjn0jkDfKXM2VwczTqAx16xjHDIivofsKNvfEjLj0VMtfGaMnnoLy0G7CYCaBlwz37GuEYyh9GTp++OTJAkaI7LVvJilP+jVBmBUAaBZMjpLFdqAKM2yHucdOFBUn8BBLqdpo28UVCLRD1xo6iCpUpHi4=; Received: from e0022681537dd.dyn.arm.linux.org.uk ([2002:4e20:1eda:1:222:68ff:fe15:37dd]:39594 helo=rmk-PC.arm.linux.org.uk) by caramon.arm.linux.org.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1TKTgR-00086v-2x; Sat, 06 Oct 2012 13:40:43 +0100 Received: from rmk by rmk-PC.arm.linux.org.uk with local (Exim 4.76) (envelope-from ) id 1TKTgQ-0002mf-6v; Sat, 06 Oct 2012 13:40:42 +0100 In-Reply-To: <20121006123803.GD15246@n2100.arm.linux.org.uk> References: <20121006123803.GD15246@n2100.arm.linux.org.uk> From: Russell King To: Tony Lindgren , Alan Cox , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-serial@vger.kernel.org Subject: [RFC 05/24] SERIAL: omap: no need to re-read EFR Message-Id: Date: Sat, 06 Oct 2012 13:40:42 +0100 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org There's no need to re-read EFR after we've recently written it; the register is a configuration register which doesn't change its value without us writing to it. Removing this re-reading avoids the possibility that we end up with up->efr having the ECB bit set, which should only be temporarily set when accessing the enhanced features. Signed-off-by: Russell King --- drivers/tty/serial/omap-serial.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 391087e..654dd78 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -872,8 +872,6 @@ serial_omap_set_termios(struct uart_port *port, struct ktermios *termios, serial_out(up, UART_OMAP_MDR1, up->mdr1); serial_out(up, UART_LCR, UART_LCR_CONF_MODE_B); - - up->efr = serial_in(up, UART_EFR); serial_out(up, UART_EFR, up->efr | UART_EFR_ECB); serial_out(up, UART_LCR, 0);