From patchwork Sat Oct 6 12:44:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell King X-Patchwork-Id: 1557451 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id DC0643FD56 for ; Sat, 6 Oct 2012 12:44:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755794Ab2JFMof (ORCPT ); Sat, 6 Oct 2012 08:44:35 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:47306 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755148Ab2JFMoe (ORCPT ); Sat, 6 Oct 2012 08:44:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=caramon; h=Date:Sender:Message-Id:Subject:Cc:To:From:References:In-Reply-To; bh=73FXLrbwbcduUd40Y7l6AomfdvBtvBr3mJzEYLDCwVU=; b=gXfmuUkpT1i0RFyYis6mxQofe+tS+6MM9w0eA/TGouZo1903vDTD8WdNxgj13/UwaeNHJ9MkQmJCu+N20q+TpuhIEcTfeWGUiiyjekff8mTaEQNfKts3hmW49PJ1O1D0hhIrIw2U8B/01bNKNzRU4/4WbkECbgSWRQMIQGBN65I=; Received: from e0022681537dd.dyn.arm.linux.org.uk ([2002:4e20:1eda:1:222:68ff:fe15:37dd]:39607 helo=rmk-PC.arm.linux.org.uk) by caramon.arm.linux.org.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1TKTk3-00089L-4T; Sat, 06 Oct 2012 13:44:27 +0100 Received: from rmk by rmk-PC.arm.linux.org.uk with local (Exim 4.76) (envelope-from ) id 1TKTk2-0002nS-9E; Sat, 06 Oct 2012 13:44:26 +0100 In-Reply-To: <20121006123803.GD15246@n2100.arm.linux.org.uk> References: <20121006123803.GD15246@n2100.arm.linux.org.uk> From: Russell King To: Tony Lindgren , Alan Cox , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-serial@vger.kernel.org Subject: [RFC 16/24] SERIAL: omap: simplify Message-Id: Date: Sat, 06 Oct 2012 13:44:26 +0100 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org We have the sequence: - LCR mode B - write EFR with ECB clear - LCR mode normal - LCR mode B - write EFR with ECB clear This can be simplified to just two writes: - LCR mode B - write EFR with ECB clear Signed-off-by: Russell King --- drivers/tty/serial/omap-serial.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 70c9661..da0d4b1 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -890,19 +890,11 @@ serial_omap_set_termios(struct uart_port *port, struct ktermios *termios, /* Disable access to TCR/TLR */ serial_out(up, UART_MCR, up->mcr); - serial_out(up, UART_LCR, UART_LCR_CONF_MODE_B); - serial_out(up, UART_EFR, up->efr); - serial_out(up, UART_LCR, cval); } else { /* Disable AUTORTS and AUTOCTS */ up->efr &= ~(UART_EFR_CTS | UART_EFR_RTS); - - serial_out(up, UART_LCR, UART_LCR_CONF_MODE_B); - serial_out(up, UART_EFR, up->efr); - serial_out(up, UART_LCR, cval); } - /* Software Flow Control Configuration */ serial_out(up, UART_LCR, UART_LCR_CONF_MODE_B); serial_out(up, UART_EFR, up->efr);