From patchwork Thu Aug 27 23:20:35 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: vikram pandita X-Patchwork-Id: 44358 X-Patchwork-Delegate: tony@atomide.com Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7RNKn2w024813 for ; Thu, 27 Aug 2009 23:20:50 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751142AbZH0XUp (ORCPT ); Thu, 27 Aug 2009 19:20:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751276AbZH0XUo (ORCPT ); Thu, 27 Aug 2009 19:20:44 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:43116 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142AbZH0XUo convert rfc822-to-8bit (ORCPT ); Thu, 27 Aug 2009 19:20:44 -0400 Received: from dbdp20.itg.ti.com ([172.24.170.38]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id n7RNKdsv019075; Thu, 27 Aug 2009 18:20:45 -0500 Received: from dbde71.ent.ti.com (localhost [127.0.0.1]) by dbdp20.itg.ti.com (8.13.8/8.13.8) with ESMTP id n7RNKbol028631; Fri, 28 Aug 2009 04:50:38 +0530 (IST) Received: from dbde02.ent.ti.com ([172.24.170.145]) by dbde71.ent.ti.com ([172.24.170.149]) with mapi; Fri, 28 Aug 2009 04:50:37 +0530 From: "Pandita, Vikram" To: Kevin Hilman CC: "linux-omap@vger.kernel.org" Date: Fri, 28 Aug 2009 04:50:35 +0530 Subject: FW: [PATCH 5/5] OMAP: Zoom2: Release Dbg board detect gpio Thread-Topic: [PATCH 5/5] OMAP: Zoom2: Release Dbg board detect gpio Thread-Index: AcoiitN9uIT115b2QlaZULvAuu0JQgE4hm7A Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Kevin Could you please line this trivial fix for Zoom2, just like you lined up the [PATCH 4/5] OMAP: Zoom2: Fix serial break That way my DEBUG_LL series will just be related to DEBUG_LL and nothing more on zoom2 fixes. -----Original Message----- From: Pandita, Vikram Sent: Friday, August 21, 2009 1:11 PM To: linux-omap@vger.kernel.org; linux-arm-kernel@lists.arm.linux.org.uk Cc: Pandita, Vikram Subject: [PATCH 5/5] OMAP: Zoom2: Release Dbg board detect gpio Release the Dbg board detection gpio once its purpose is served Signed-off-by: Vikram Pandita --- arch/arm/mach-omap2/board-zoom-debugboard.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/board-zoom-debugboard.c b/arch/arm/mach-omap2/board-zoom-debugboard.c index 4dd714d..d80e448 100644 --- a/arch/arm/mach-omap2/board-zoom-debugboard.c +++ b/arch/arm/mach-omap2/board-zoom-debugboard.c @@ -130,6 +130,7 @@ static inline void __init zoom2_init_quaduart(void) static inline int omap_zoom2_debugboard_detect(void) { int debug_board_detect = 0; + int ret = 1; debug_board_detect = ZOOM2_SMSC911X_GPIO; @@ -141,10 +142,10 @@ static inline int omap_zoom2_debugboard_detect(void) gpio_direction_input(debug_board_detect); if (!gpio_get_value(debug_board_detect)) { - gpio_free(debug_board_detect); - return 0; + ret = 0; } - return 1; + gpio_free(debug_board_detect); + return ret; } static struct platform_device *zoom2_devices[] __initdata = {