From patchwork Mon Aug 3 01:20:45 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paul Walmsley X-Patchwork-Id: 38818 X-Patchwork-Delegate: khilman@deeprootsystems.com Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n731Km0p019645 for ; Mon, 3 Aug 2009 01:20:48 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752032AbZHCBUq (ORCPT ); Sun, 2 Aug 2009 21:20:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753295AbZHCBUq (ORCPT ); Sun, 2 Aug 2009 21:20:46 -0400 Received: from utopia.booyaka.com ([72.9.107.138]:44683 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752032AbZHCBUp (ORCPT ); Sun, 2 Aug 2009 21:20:45 -0400 Received: (qmail 3902 invoked by uid 526); 3 Aug 2009 01:20:45 -0000 Date: Sun, 2 Aug 2009 19:20:45 -0600 (MDT) From: Paul Walmsley To: John Sarman cc: linux-omap Subject: Re: MMC3 Overo In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hello John, you are using the PM branch, correct? On Thu, 30 Jul 2009, John Sarman wrote: > On Thu, Jul 30, 2009 at 11:49 AM, John Sarman wrote: > > I am trying to use mmc3 on the Overo Gumstix board with no luck.  I > > have patched the kernel with the latest changes and have yet to see a > > clk pulse, both before and after the patches. > After adding some debugging printks, I have determined the mmc3 fails > getting IRQ > mmci-omap-hs mmci-omap-hs.0: Failed to get debounce clock > REQUEST IRQ = 83 HOST = -812068416 > mmci-omap-hs mmci-omap-hs.1: Failed to get debounce clock > REQUEST IRQ = 86 HOST = -812067392 > mmci-omap-hs mmci-omap-hs.2: Failed to get debounce clock > REQUEST IRQ = 83 HOST = -812066368 > mmci-omap-hs mmci-omap-hs.2: Unable to grab HSMMC IRQ > mmci-omap-hs mmci-omap-hs.2: Probe Failed > mmci-omap-hs: probe of mmci-omap-hs.2 failed with error -16 > > For some reason mmc1 and mmc3 ask for the same interrupt 83 ??? > > Why would this be assigned the same value? Developer error. Does this patch fix it for you? - Paul From baca68c40ec3b391cdbfc0fb20ac5092b4ab7025 Mon Sep 17 00:00:00 2001 From: Paul Walmsley Date: Mon, 3 Aug 2009 04:18:45 +0300 Subject: [PATCH] OMAP3 hwmod: fix MMC3 IRQ The MMC3 IRQ is incorrect in mach-omap2/omap_hwmod_34xx.h, which causes MMC3 init to fail. Signed-off-by: Paul Walmsley --- arch/arm/mach-omap2/omap_hwmod_34xx.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_34xx.h b/arch/arm/mach-omap2/omap_hwmod_34xx.h index 29a2d60..56215bd 100644 --- a/arch/arm/mach-omap2/omap_hwmod_34xx.h +++ b/arch/arm/mach-omap2/omap_hwmod_34xx.h @@ -470,7 +470,7 @@ static struct omap_hwmod omap34xx_mmc2_hwmod = { static struct mmc_dev_attr mmc3_dev_attr; static u8 mmc3_mpu_irqs[] = { - INT_24XX_MMC_IRQ, + INT_34XX_MMC3_IRQ, }; static struct omap_hwmod_dma_info mmc3_sdma_chs[] = {