From patchwork Sat Apr 17 05:29:03 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bharathi Subramanian X-Patchwork-Id: 93284 X-Patchwork-Delegate: tomi.valkeinen@nokia.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o3H5TEbv018399 for ; Sat, 17 Apr 2010 05:29:14 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752290Ab0DQF3H (ORCPT ); Sat, 17 Apr 2010 01:29:07 -0400 Received: from mail-pz0-f204.google.com ([209.85.222.204]:60614 "EHLO mail-pz0-f204.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751578Ab0DQF3G (ORCPT ); Sat, 17 Apr 2010 01:29:06 -0400 Received: by pzk42 with SMTP id 42so2459640pzk.4 for ; Fri, 16 Apr 2010 22:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:received:message-id :subject:from:to:content-type; bh=TWycPLcuNIGprNWO+/Lw1O9bk606DAluAcp4LNearik=; b=vjXyLpxGmAFZ6xkPW9WGq2jo9438uUT+Oh6Gkgt2ASPykGIqmYmELlaQsXZAYzPwEo QVMBTnEu67saHdZTQ8YbgqxdyLzZ+saU0ZQUMMCuH5oAHqkZboo5MbzPhoR/usWPwOSB 0TlcgKk6p/d1pAJAoym1L4E4Dqnpb5V62LueY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=DNXOYhYU7pZ7oqwJRAKnyMSmmAgtxI6eQdrjewq3b4JmW9NsLLIQbc+9lWX71OhIGv 6B1Vbr4DvxvnSckoam8pNuzCbP8JrA7bll62vrKQkT5WypBinbDJuj55WbeeNYm0Vzqs cx+6omjFdkQ/7yFxgwj2R8NAHjibLJLgx7tEU= MIME-Version: 1.0 Received: by 10.114.132.17 with HTTP; Fri, 16 Apr 2010 22:29:03 -0700 (PDT) Date: Sat, 17 Apr 2010 10:59:03 +0530 Received: by 10.115.39.17 with SMTP id r17mr2528354waj.40.1271482143486; Fri, 16 Apr 2010 22:29:03 -0700 (PDT) Message-ID: Subject: [PATCH] DSS2: Code Clean-up From: Bharathi Subramanian To: linux-omap Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Sat, 17 Apr 2010 05:29:15 +0000 (UTC) diff --git a/drivers/video/omap2/dss/display.c b/drivers/video/omap2/dss/display.c index 6a74ea1..a5a6859 100644 --- a/drivers/video/omap2/dss/display.c +++ b/drivers/video/omap2/dss/display.c @@ -340,10 +340,11 @@ int omapdss_default_get_recommended_bpp(struct omap_dss_device *dssdev) return 24; else return 16; + case OMAP_DISPLAY_TYPE_VENC: case OMAP_DISPLAY_TYPE_SDI: return 24; - return 24; + default: BUG(); } diff --git a/drivers/video/omap2/dss/venc.c b/drivers/video/omap2/dss/venc.c index f0ba573..0185782 100644 --- a/drivers/video/omap2/dss/venc.c +++ b/drivers/video/omap2/dss/venc.c @@ -450,10 +450,6 @@ static void venc_power_off(struct omap_dss_device *dssdev) venc_enable_clocks(0); } - - - - /* driver */ static int venc_panel_probe(struct omap_dss_device *dssdev) { @@ -654,8 +650,6 @@ static struct omap_dss_driver venc_driver = { }; /* driver end */ - - int venc_init(struct platform_device *pdev) { u8 rev_id; diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c index 4a76917..6d72784 100644 --- a/drivers/video/omap2/omapfb/omapfb-main.c +++ b/drivers/video/omap2/omapfb/omapfb-main.c @@ -1771,8 +1771,7 @@ static int omapfb_fb_init(struct omapfb2_device *fbdev, struct fb_info *fbi) var->bits_per_pixel = 32; break; default: - dev_err(fbdev->dev, "illegal display " - "bpp\n"); + dev_err(fbdev->dev, "illegal display bpp\n"); return -EINVAL; }