From patchwork Mon Apr 19 15:36:36 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kishore kadiyala X-Patchwork-Id: 93513 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o3JFbA8c000834 for ; Mon, 19 Apr 2010 15:37:10 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751440Ab0DSPgr (ORCPT ); Mon, 19 Apr 2010 11:36:47 -0400 Received: from fg-out-1718.google.com ([72.14.220.156]:20089 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715Ab0DSPgq (ORCPT ); Mon, 19 Apr 2010 11:36:46 -0400 Received: by fg-out-1718.google.com with SMTP id d23so2006822fga.1 for ; Mon, 19 Apr 2010 08:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type; bh=K7yuUBKt2rxte2qBIqkb0yRivo3yV11GbI3Cdejvd/I=; b=M28uNKBfXnQu27toEjZ1vgd58wMNliH/EYSeUT4a7Eu406TJFTpGhWBt2vGfdI+8Mo dYKBAILGAW+Dw0IBg/mBaqZCG4D+Xez8p5Ohz0wApm47HkvOiC/IrJ+avEz72OYfBuyH C46L0gRK1BZgX9MV3eyulQcTdiocByurxA0jI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=e5Gd7eANC0KgTZM0BvKn77FKpFyv3jAtTJ5ZYRk7kdNOYfNFQyaFT9UhPN3p2sEtF4 OsWjAzNwF5VXs/m5J3lDMCkVnjss1giOQw0MGo6C4xgD/sGcIsAB79xI94l2udnTkEQ2 nYJnY48LKje0rxqZBbgUQHyu9D1G0QyA10r0k= MIME-Version: 1.0 Received: by 10.223.103.209 with HTTP; Mon, 19 Apr 2010 08:36:36 -0700 (PDT) In-Reply-To: <003601cad73c$98c3aa50$544ff780@am.dhcp.ti.com> References: <003b01cad0f0$6ea78040$544ff780@am.dhcp.ti.com> <003901cad5a4$730264d0$544ff780@am.dhcp.ti.com> <20100406163211.GA29117@nokia.com> <4BBB6767.7010202@ti.com> <20100406165720.GA17916@nokia.com> <00b401cad5e0$1d1868d0$544ff780@am.dhcp.ti.com> <4BBBC628.9030207@ti.com> <00c901cad5e7$9de54350$544ff780@am.dhcp.ti.com> <4BBBD87C.1040307@ti.com> <003601cad73c$98c3aa50$544ff780@am.dhcp.ti.com> Date: Mon, 19 Apr 2010 21:06:36 +0530 Received: by 10.223.132.210 with SMTP id c18mr179185fat.48.1271691396877; Mon, 19 Apr 2010 08:36:36 -0700 (PDT) Message-ID: Subject: [PATCH v4] OMAP: Fix for bus width which improves SD card's peformance. From: kishore kadiyala To: Madhusudhan Cc: Nishanth Menon , felipe.balbi@nokia.com, me@felipebalbi.com, Vimal Singh , tony@atomide.com, "S, Venkatraman" , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, "Lavinen Jarkko (Nokia-D/Helsinki)" Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Mon, 19 Apr 2010 15:37:13 +0000 (UTC) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 8c97c22..9c1a60e 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -2091,10 +2091,23 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev) mmc->caps |= MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED | MMC_CAP_WAIT_WHILE_BUSY; - if (mmc_slot(host).wires >= 8) - mmc->caps |= (MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA); - else if (mmc_slot(host).wires >= 4) + switch (mmc_slot(host).wires) { + case 8: + mmc->caps |= MMC_CAP_8_BIT_DATA; + /* Fall through */ + case 4: mmc->caps |= MMC_CAP_4_BIT_DATA; + break; + case 1: + /* Nothing to crib here */ + case 0: + /* Assuming nothing was given by board, Core use's 1-Bit */ + break; + default: + /* Completely unexpected.. Core goes with 1-Bit Width */ + dev_crit(mmc_dev(host->mmc), "Invalid width %d\n used!" + "using 1 instead\n", mmc_slot(host).wires); + } if (mmc_slot(host).nonremovable)