| Message ID | 20201008154651.1901126-1-arnd@arndb.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | Clean up legacy clock tick users | expand |
On Thu, Oct 8, 2020 at 5:47 PM Arnd Bergmann <arnd@arndb.de> wrote: > When I created the patch removing CONFIG_ARCH_GETTIMEOFFSET, > I also had a look at CONFIG_GENERIC_CLOCKEVENTS, which is > selected by most, but not all, platforms today, each of the > ones that lack it doing the timer tick slightly differently. > > The cleanups here make the old platforms a bit more > consistent, in multiple ways: > > - rather than selecting GENERIC_CLOCKEVENTS on modern > platforms, select LEGACY_TIMER_TICK on the old ones. > > - Hide some more of the internal implementation and only > provide a single common entry point for the timer tick, > which also makes the behavior more consistent. > > - Remove the m68k and arm specific infrastructure pieces > and call the common helper directly from each timer > interrupt function. > > I tested the series on m68k with the qemu q800 target > platform, both with the legacy_timer_tick() implementation > and after converting that to a periodic clockevent driver. I am a big fan of this patch series: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Maybe the RFC patch can be kept in the sidelines but the rest should be merged ASAP in my opinion, the kernel just looks so much better after this. Yours, Linus Walleij
When I created the patch removing CONFIG_ARCH_GETTIMEOFFSET, I also had a look at CONFIG_GENERIC_CLOCKEVENTS, which is selected by most, but not all, platforms today, each of the ones that lack it doing the timer tick slightly differently. The cleanups here make the old platforms a bit more consistent, in multiple ways: - rather than selecting GENERIC_CLOCKEVENTS on modern platforms, select LEGACY_TIMER_TICK on the old ones. - Hide some more of the internal implementation and only provide a single common entry point for the timer tick, which also makes the behavior more consistent. - Remove the m68k and arm specific infrastructure pieces and call the common helper directly from each timer interrupt function. I tested the series on m68k with the qemu q800 target platform, both with the legacy_timer_tick() implementation and after converting that to a periodic clockevent driver. Arnd Arnd Bergmann (13): timekeeping: add CONFIG_LEGACY_TIMER_TICK ia64: convert to legacy_timer_tick ARM: rpc: use legacy_timer_tick parisc: use legacy_timer_tick m68k: coldfire: use legacy_timer_tick() m68k: split heartbeat out of timer function m68k: sun3/sun3c: use legacy_timer_tick m68k: m68328: use legacy_timer_tick() m68k: change remaining timers to legacy_timer_tick m68k: remove timer_interrupt() function timekeeping: remove xtime_update timekeeping: default GENERIC_CLOCKEVENTS to enabled [RFC] m68k: mac: convert to generic clockevent .../time/clockevents/arch-support.txt | 8 ++-- arch/alpha/Kconfig | 1 - arch/arc/Kconfig | 1 - arch/arm/Kconfig | 13 +----- arch/arm/include/asm/mach/time.h | 2 - arch/arm/kernel/time.c | 14 ------ arch/arm/mach-rpc/time.c | 2 +- arch/arm64/Kconfig | 1 - arch/arm64/Kconfig.platforms | 1 - arch/c6x/Kconfig | 1 - arch/csky/Kconfig | 1 - arch/h8300/Kconfig | 1 - arch/hexagon/Kconfig | 1 - arch/ia64/Kconfig | 1 + arch/ia64/kernel/time.c | 36 ++++++--------- arch/m68k/68000/timers.c | 7 ++- arch/m68k/Kconfig.cpu | 34 +++++++++++--- arch/m68k/Kconfig.machine | 15 +++++++ arch/m68k/amiga/config.c | 11 +++-- arch/m68k/apollo/config.c | 11 +++-- arch/m68k/atari/config.c | 2 +- arch/m68k/atari/time.c | 9 ++-- arch/m68k/bvme6000/config.c | 9 ++-- arch/m68k/coldfire/Makefile | 32 ++++++++------ arch/m68k/coldfire/pit.c | 2 +- arch/m68k/coldfire/sltimers.c | 8 ++-- arch/m68k/coldfire/timers.c | 8 ++-- arch/m68k/hp300/time.c | 8 ++-- arch/m68k/hp300/time.h | 2 +- arch/m68k/include/asm/machdep.h | 12 +++-- arch/m68k/kernel/setup_mm.c | 2 +- arch/m68k/kernel/setup_no.c | 2 +- arch/m68k/kernel/time.c | 18 ++------ arch/m68k/mac/config.c | 6 +-- arch/m68k/mac/via.c | 44 +++++++++++++++---- arch/m68k/mvme147/config.c | 9 ++-- arch/m68k/mvme16x/config.c | 9 ++-- arch/m68k/q40/config.c | 2 +- arch/m68k/q40/q40ints.c | 10 ++--- arch/m68k/sun3/config.c | 4 +- arch/m68k/sun3/sun3ints.c | 3 +- arch/m68k/sun3x/time.c | 5 +-- arch/m68k/sun3x/time.h | 2 +- arch/microblaze/Kconfig | 1 - arch/mips/Kconfig | 1 - arch/nds32/Kconfig | 1 - arch/nios2/Kconfig | 1 - arch/openrisc/Kconfig | 1 - arch/parisc/Kconfig | 2 +- arch/parisc/kernel/time.c | 9 ++-- arch/powerpc/Kconfig | 1 - arch/riscv/Kconfig | 1 - arch/s390/Kconfig | 1 - arch/sh/Kconfig | 1 - arch/sparc/Kconfig | 1 - arch/um/Kconfig | 1 - arch/x86/Kconfig | 1 - arch/xtensa/Kconfig | 1 - include/linux/timekeeping.h | 5 +-- kernel/time/Kconfig | 9 +++- kernel/time/Makefile | 1 + kernel/time/tick-legacy.c | 37 ++++++++++++++++ kernel/time/timekeeping.c | 16 ------- kernel/time/timekeeping.h | 1 + 64 files changed, 242 insertions(+), 221 deletions(-) create mode 100644 kernel/time/tick-legacy.c Cc: Russell King <linux@armlinux.org.uk> Cc: Tony Luck <tony.luck@intel.com> Cc: Fenghua Yu <fenghua.yu@intel.com> Cc: Greg Ungerer <gerg@linux-m68k.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Finn Thain <fthain@telegraphics.com.au> Cc: Philip Blundell <philb@gnu.org> Cc: Joshua Thompson <funaho@jurai.org> Cc: Sam Creasey <sammy@sammy.net> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com> Cc: Helge Deller <deller@gmx.de> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> Cc: John Stultz <john.stultz@linaro.org> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: linux-kernel@vger.kernel.org Cc: linux-ia64@vger.kernel.org Cc: linux-parisc@vger.kernel.org Cc: linux-m68k@lists.linux-m68k.org Cc: linux-arm-kernel@lists.infradead.org