| Message ID | 1457554123-18491-3-git-send-email-aaro.koskinen@iki.fi (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 09.03.2016 21:08, Aaro Koskinen wrote: > PA-RISC wants to sleep 5 seconds before panicking when panic_on_oops > is set, with no apparent reason. That's not completely true. A few years back, when we had lots of crashes, it was very useful to at least have some time to see the crash before the oops was cleaned from the screen. Today the parisc port is really stable. > Remove this feature, since some users > may want their systems to fail as quickly as possible. > > Users who want to delay reboot after panic can use PANIC_TIMEOUT. That's OK. > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Acked-by: Helge Deller <deller@gmx.de> > --- > arch/parisc/kernel/traps.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/parisc/kernel/traps.c b/arch/parisc/kernel/traps.c > index 553b098..16e0735 100644 > --- a/arch/parisc/kernel/traps.c > +++ b/arch/parisc/kernel/traps.c > @@ -284,11 +284,8 @@ void die_if_kernel(char *str, struct pt_regs *regs, long err) > if (in_interrupt()) > panic("Fatal exception in interrupt"); > > - if (panic_on_oops) { > - printk(KERN_EMERG "Fatal exception: panic in 5 seconds\n"); > - ssleep(5); > + if (panic_on_oops) > panic("Fatal exception"); > - } > > oops_exit(); > do_exit(SIGSEGV); > -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/parisc/kernel/traps.c b/arch/parisc/kernel/traps.c index 553b098..16e0735 100644 --- a/arch/parisc/kernel/traps.c +++ b/arch/parisc/kernel/traps.c @@ -284,11 +284,8 @@ void die_if_kernel(char *str, struct pt_regs *regs, long err) if (in_interrupt()) panic("Fatal exception in interrupt"); - if (panic_on_oops) { - printk(KERN_EMERG "Fatal exception: panic in 5 seconds\n"); - ssleep(5); + if (panic_on_oops) panic("Fatal exception"); - } oops_exit(); do_exit(SIGSEGV);
PA-RISC wants to sleep 5 seconds before panicking when panic_on_oops is set, with no apparent reason. Remove this feature, since some users may want their systems to fail as quickly as possible. Users who want to delay reboot after panic can use PANIC_TIMEOUT. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> --- arch/parisc/kernel/traps.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)