From patchwork Tue Feb 5 16:03:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Wei X-Patchwork-Id: 10797617 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 06B8C6C2 for ; Tue, 5 Feb 2019 16:04:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9674220499 for ; Tue, 5 Feb 2019 16:04:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8AF9027B2F; Tue, 5 Feb 2019 16:04:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 223D120499 for ; Tue, 5 Feb 2019 16:04:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730242AbfBEQEC (ORCPT ); Tue, 5 Feb 2019 11:04:02 -0500 Received: from m12-11.163.com ([220.181.12.11]:32882 "EHLO m12-11.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727250AbfBEQEC (ORCPT ); Tue, 5 Feb 2019 11:04:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=PbiksNVUy6d9Ohk7Ly aggvBbSuScXKXUQPacO5mUQR0=; b=bvzH2BCnnUwqm3HWQwNEaU6gWEEvfH04xQ NC4PvBi9hJOgZI8po/GjRS/585XxU8VOIGovS/kVLmucTtYTlQ45v/qUm2V7RwmX TC128le6Yrhi2JtcawNmn/2Ol3fa4gEsjR2K4kUjyaq9AKIG19zKyXQYHL+dlf4C JiX7WsOJQ= Received: from localhost.localdomain (unknown [171.210.152.198]) by smtp7 (Coremail) with SMTP id C8CowADHpnbps1lcSlEvEQ--.44068S3; Wed, 06 Feb 2019 00:03:54 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org, linux-parisc@vger.kernel.org Cc: davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: tulip: de2104x: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Wed, 6 Feb 2019 00:03:51 +0800 Message-Id: <1549382631-5211-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: C8CowADHpnbps1lcSlEvEQ--.44068S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF1DZF4UCF1UJFyftFb_yoW3CrX_Ww 10v3Wftw45Ar90k3sxKFsY9FyS9r1kWF4rAFySqrW3X342yr1jvrWkZr9xGr98Gw4rXFnr Gry2qr4fZ345AjkaLaAFLSUrUUUUnb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnDfHUUUUUU== X-Originating-IP: [171.210.152.198] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiqwpSolUMOAmQOAAAsR Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yang Wei dev_consume_skb_irq() should be called in de_tx() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/dec/tulip/de2104x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c index 13430f7..f1a2da1 100644 --- a/drivers/net/ethernet/dec/tulip/de2104x.c +++ b/drivers/net/ethernet/dec/tulip/de2104x.c @@ -585,7 +585,7 @@ static void de_tx (struct de_private *de) netif_dbg(de, tx_done, de->dev, "tx done, slot %d\n", tx_tail); } - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); } next: