From patchwork Sat Apr 4 20:54:26 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastian Blank X-Patchwork-Id: 16350 X-Patchwork-Delegate: kyle@mcmartin.ca Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n34L1wOQ018028 for ; Sat, 4 Apr 2009 21:01:58 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751027AbZDDVB7 (ORCPT ); Sat, 4 Apr 2009 17:01:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754005AbZDDVB7 (ORCPT ); Sat, 4 Apr 2009 17:01:59 -0400 Received: from wavehammer.waldi.eu.org ([82.139.201.20]:51620 "EHLO wavehammer.waldi.eu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027AbZDDVB6 (ORCPT ); Sat, 4 Apr 2009 17:01:58 -0400 X-Greylist: delayed 447 seconds by postgrey-1.27 at vger.kernel.org; Sat, 04 Apr 2009 17:01:58 EDT Received: by wavehammer.waldi.eu.org (Postfix, from userid 1000) id D81EF54201; Sat, 4 Apr 2009 22:54:26 +0200 (CEST) Date: Sat, 4 Apr 2009 22:54:26 +0200 From: Bastian Blank To: linux-parisc@vger.kernel.org Subject: [PATCH] Remove casts from atomic macros Message-ID: <20090404205426.GA27225@wavehammer.waldi.eu.org> Mail-Followup-To: Bastian Blank , linux-parisc@vger.kernel.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org The atomic operations on parisc are defined as macros. The macros includes casts which disallows the use of some syntax elements and produces error like this: net/phonet/pep.c: In function 'pipe_rcv_status': net/phonet/pep.c:262: error: lvalue required as left operand of assignment The patch removes this superfluous casts. Signed-off-by: Bastian Blank --- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/parisc/include/asm/atomic.h b/arch/parisc/include/asm/atomic.h index edbfe25..43e101b 100644 --- a/arch/parisc/include/asm/atomic.h +++ b/arch/parisc/include/asm/atomic.h @@ -222,13 +222,13 @@ static __inline__ int atomic_add_unless(atomic_t *v, int a, int u) #define atomic_inc_not_zero(v) atomic_add_unless((v), 1, 0) -#define atomic_add(i,v) ((void)(__atomic_add_return( ((int)i),(v)))) -#define atomic_sub(i,v) ((void)(__atomic_add_return(-((int)i),(v)))) +#define atomic_add(i,v) ((void)(__atomic_add_return( (i),(v)))) +#define atomic_sub(i,v) ((void)(__atomic_add_return(-(i),(v)))) #define atomic_inc(v) ((void)(__atomic_add_return( 1,(v)))) #define atomic_dec(v) ((void)(__atomic_add_return( -1,(v)))) -#define atomic_add_return(i,v) (__atomic_add_return( ((int)i),(v))) -#define atomic_sub_return(i,v) (__atomic_add_return(-((int)i),(v))) +#define atomic_add_return(i,v) (__atomic_add_return( (i),(v))) +#define atomic_sub_return(i,v) (__atomic_add_return(-(i),(v))) #define atomic_inc_return(v) (__atomic_add_return( 1,(v))) #define atomic_dec_return(v) (__atomic_add_return( -1,(v)))