From patchwork Wed Aug 19 19:04:10 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Grundler X-Patchwork-Id: 42770 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7JJ4DKC032435 for ; Wed, 19 Aug 2009 19:04:13 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752035AbZHSTEK (ORCPT ); Wed, 19 Aug 2009 15:04:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752049AbZHSTEK (ORCPT ); Wed, 19 Aug 2009 15:04:10 -0400 Received: from complete.lackof.org ([198.49.126.79]:44110 "EHLO complete.lackof.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752035AbZHSTEJ (ORCPT ); Wed, 19 Aug 2009 15:04:09 -0400 Received: from localhost (localhost [127.0.0.1]) by complete.lackof.org (Postfix) with ESMTP id DBE2433E0007; Wed, 19 Aug 2009 13:04:10 -0600 (MDT) X-Virus-Scanned: Debian amavisd-new at lackof.org Received: from complete.lackof.org ([127.0.0.1]) by localhost (complete.lackof.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YAZQapxHVmHI; Wed, 19 Aug 2009 13:04:10 -0600 (MDT) Received: by complete.lackof.org (Postfix, from userid 27253) id 9026D33E005C; Wed, 19 Aug 2009 13:04:10 -0600 (MDT) Date: Wed, 19 Aug 2009 13:04:10 -0600 From: Grant Grundler To: Kyle McMartin , Helge Deller Cc: John David Anglin , linux-parisc@vger.kernel.org Subject: PATCH [2.6.31-rc6] fix warning in traps.c line 535 Message-ID: <20090819190410.GB24471@lackof.org> References: <20090817234554.GD26336@lackof.org> <20090818174518.6E0EA4CFD@hiauly1.hia.nrc.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20090818174518.6E0EA4CFD@hiauly1.hia.nrc.ca> X-Home-Page: http://www.parisc-linux.org/ User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Tue, Aug 18, 2009 at 01:45:17PM -0400, John David Anglin wrote: ... > There's one new parisc warning that I noticed: > > CC arch/parisc/kernel/traps.o > arch/parisc/kernel/traps.c: In function 'handle_interruption': > arch/parisc/kernel/traps.c:535:18: warning: operation on 'regs->iasq[0]' may be > undefined > > Looks like a typo. Yes - Line 535 should use both [0] and [1]. Signed-off-by: Grant Grundler ---- --- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/parisc/kernel/traps.c b/arch/parisc/kernel/traps.c index 528f0ff..8b58bf0 100644 --- a/arch/parisc/kernel/traps.c +++ b/arch/parisc/kernel/traps.c @@ -532,7 +532,7 @@ void notrace handle_interruption(int code, struct pt_regs *regs) /* Kill the user process later */ regs->iaoq[0] = 0 | 3; regs->iaoq[1] = regs->iaoq[0] + 4; - regs->iasq[0] = regs->iasq[0] = regs->sr[7]; + regs->iasq[0] = regs->iasq[1] = regs->sr[7]; regs->gr[0] &= ~PSW_B; return; }