From patchwork Tue Aug 19 20:30:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 4745781 Return-Path: X-Original-To: patchwork-linux-parisc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 074E3C0338 for ; Tue, 19 Aug 2014 20:36:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 277092013A for ; Tue, 19 Aug 2014 20:36:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B31920103 for ; Tue, 19 Aug 2014 20:36:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750985AbaHSUgr (ORCPT ); Tue, 19 Aug 2014 16:36:47 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:54156 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbaHSUgq (ORCPT ); Tue, 19 Aug 2014 16:36:46 -0400 X-Greylist: delayed 344 seconds by postgrey-1.27 at vger.kernel.org; Tue, 19 Aug 2014 16:36:45 EDT Received: from localhost (localhost [127.0.0.1]) by asavdk3.altibox.net (Postfix) with ESMTP id 56F0F20022; Tue, 19 Aug 2014 22:30:59 +0200 (CEST) Received: from asavdk3.altibox.net ([127.0.0.1]) by localhost (asavdk3.lysetele.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id o1wDTrZq7gRD; Tue, 19 Aug 2014 22:30:59 +0200 (CEST) Received: from ravnborg.org (unknown [188.228.89.252]) (using TLSv1.2 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 7300C20020; Tue, 19 Aug 2014 22:30:56 +0200 (CEST) Date: Tue, 19 Aug 2014 22:30:55 +0200 From: Sam Ravnborg To: Aaro Koskinen Cc: James Bottomley , Meelis Roos , linux-scsi@vger.kernel.org, sparclinux@vger.kernel.org, Matthew Wilcox , linux-parisc@vger.kernel.org, Christoph Hellwig Subject: Re: Sym2 scsi hang on boot on sparc64 Message-ID: <20140819203054.GA24325@ravnborg.org> References: <1408451668.2645.2.camel@jarvis> <1408459655.3491.1.camel@jarvis> <20140819201748.GC4885@drone.musicnaut.iki.fi> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140819201748.GC4885@drone.musicnaut.iki.fi> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Aug 19, 2014 at 11:17:48PM +0300, Aaro Koskinen wrote: > Hi, > > On Tue, Aug 19, 2014 at 09:47:35AM -0500, James Bottomley wrote: > > On Tue, 2014-08-19 at 17:37 +0300, Meelis Roos wrote: > > > > On Tue, 2014-08-19 at 14:25 +0300, Meelis Roos wrote: > > > > > 3.16 scsi worked fine, 3.17-rc1 misbehaves on 3 of my sparc64 test > > > > > machines. E220R and E420R are with onboard 5c3875, V210 is with onboarc > > > > > 53c1010 and all behave the same. Any ideas whre to dig deeper? bisection > > > > > might be nontrivial, because of sparc64 changes that are OK on 3.17-rc1 > > > > > again - but is possible if nothing else helps. > > > > > > > > We've got a parisc with an 875 as a root SCSI bus ... I haven't got > > > > around to building for it yet, but I might find time to try today. > > > > > > Same on parisc: > > > > > > sym0: <1010-66> rev 0x1 at pci 0000:20:01.0 irq 22 > > > sym0: PA-RISC Firmware, ID 7, Fast-80, LVD, parity checking > > > sym0: SCSI BUS has been reset. > > > scsi host0: sym-2.2.3 > > > random: nonblocking pool is initialized > > > > > > and hangs here. So hopefully it is reproducible for you. > > > > And also independent of the sparc changes. The only other change in the > > window you quote is 64 bit luns. > > Bisection (on PA-RISC) points to: > > 71e75c97f97a9645d25fbf3d8e4165a558f18747 is the first bad commit > commit 71e75c97f97a9645d25fbf3d8e4165a558f18747 > Author: Christoph Hellwig > Date: Fri Apr 11 19:07:01 2014 +0200 > > scsi: convert device_busy to atomic_t I guess you need this fix: James already sent it to Linus. Sam --- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 9c44392..ce62e87 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -1774,7 +1774,7 @@ static void scsi_request_fn(struct request_queue *q) blk_requeue_request(q, req); atomic_dec(&sdev->device_busy); out_delay: - if (atomic_read(&sdev->device_busy) && !scsi_device_blocked(sdev)) + if (!atomic_read(&sdev->device_busy) && !scsi_device_blocked(sdev)) blk_delay_queue(q, SCSI_QUEUE_DELAY); }