| Message ID | 20190107095612.7086-1-sergey.senozhatsky@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | parisc: replace oops_in_progress manipulation with bust_spinlocks() | expand |
On 07.01.19 10:56, Sergey Senozhatsky wrote: > Use bust_spinlocks() function to set oops_in_progress. > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> I've added this patch to the parisc for-next tree. Thanks, Helge > --- > arch/parisc/kernel/traps.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/parisc/kernel/traps.c b/arch/parisc/kernel/traps.c > index 472a818e8c17..7e1ccafadf57 100644 > --- a/arch/parisc/kernel/traps.c > +++ b/arch/parisc/kernel/traps.c > @@ -218,7 +218,7 @@ void die_if_kernel(char *str, struct pt_regs *regs, long err) > return; > } > > - oops_in_progress = 1; > + bust_spinlocks(1); > > oops_enter(); > > @@ -396,7 +396,7 @@ void parisc_terminate(char *msg, struct pt_regs *regs, int code, unsigned long o > { > static DEFINE_SPINLOCK(terminate_lock); > > - oops_in_progress = 1; > + bust_spinlocks(1); > > set_eiem(0); > local_irq_disable(); >
On (01/08/19 08:44), Helge Deller wrote: > Date: Tue, 8 Jan 2019 08:44:19 +0100 > From: Helge Deller <deller@gmx.de> > To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>, "James E . J . > Bottomley" <jejb@parisc-linux.org> > Cc: linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey > Senozhatsky <sergey.senozhatsky@gmail.com> > Subject: Re: [PATCH] parisc: replace oops_in_progress manipulation with > bust_spinlocks() > Message-ID: <d09f4a9a-f966-80d7-01e1-5d92401b5d7e@gmx.de> > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 > Thunderbird/60.4.0 > > On 07.01.19 10:56, Sergey Senozhatsky wrote: > > Use bust_spinlocks() function to set oops_in_progress. > > > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > > I've added this patch to the parisc for-next tree. Thanks. BTW, jejb at parisc-linux.org bounces. Shall it be replaced with HansenPartnership.com email address? --- diff --git a/MAINTAINERS b/MAINTAINERS index 7fc7813cd9c2..86b174dbe506 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11511,7 +11511,7 @@ F: Documentation/blockdev/paride.txt F: drivers/block/paride/ PARISC ARCHITECTURE -M: "James E.J. Bottomley" <jejb@parisc-linux.org> +M: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com> M: Helge Deller <deller@gmx.de> L: linux-parisc@vger.kernel.org W: http://www.parisc-linux.org/
I didn't pay enough attention. Seems to be a temp problem on parisc-linux.org side: : There was a temporary problem delivering your message to jejb at parisc-linux.org. : : The response was: : : The recipient server did not accept our requests to connect. : [mail.parisc-linux.org. 140.ZZZ.X.YY: generic::failed_precondition: connect error (0): error] -ss
On 09.01.19 06:39, Sergey Senozhatsky wrote: > On (01/08/19 08:44), Helge Deller wrote: >> Date: Tue, 8 Jan 2019 08:44:19 +0100 >> From: Helge Deller <deller@gmx.de> >> To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>, "James E . J . >> Bottomley" <jejb@parisc-linux.org> >> Cc: linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey >> Senozhatsky <sergey.senozhatsky@gmail.com> >> Subject: Re: [PATCH] parisc: replace oops_in_progress manipulation with >> bust_spinlocks() >> Message-ID: <d09f4a9a-f966-80d7-01e1-5d92401b5d7e@gmx.de> >> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 >> Thunderbird/60.4.0 >> >> On 07.01.19 10:56, Sergey Senozhatsky wrote: >>> Use bust_spinlocks() function to set oops_in_progress. >>> >>> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> >> >> I've added this patch to the parisc for-next tree. > > Thanks. > > BTW, > jejb at parisc-linux.org bounces. Shall it be replaced with > HansenPartnership.com email address? > > --- > > diff --git a/MAINTAINERS b/MAINTAINERS > index 7fc7813cd9c2..86b174dbe506 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11511,7 +11511,7 @@ F: Documentation/blockdev/paride.txt > F: drivers/block/paride/ > > PARISC ARCHITECTURE > -M: "James E.J. Bottomley" <jejb@parisc-linux.org> > +M: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com> > M: Helge Deller <deller@gmx.de> > L: linux-parisc@vger.kernel.org > W: http://www.parisc-linux.org/ > I prefer that change. In my role as admin of the parisc-linux.org domain I plan to retire all @parisc-linux.org email addresses soon anyway. Helge
On (01/09/19 08:16), Helge Deller wrote: > I prefer that change. > In my role as admin of the parisc-linux.org domain I plan to retire > all @parisc-linux.org email addresses soon anyway. I see. Well, I can send a formal patch, but I think James would know better which one of his email addresses he'd prefer to use; so it seems that a patch from James would be more appropriate. -ss
diff --git a/arch/parisc/kernel/traps.c b/arch/parisc/kernel/traps.c index 472a818e8c17..7e1ccafadf57 100644 --- a/arch/parisc/kernel/traps.c +++ b/arch/parisc/kernel/traps.c @@ -218,7 +218,7 @@ void die_if_kernel(char *str, struct pt_regs *regs, long err) return; } - oops_in_progress = 1; + bust_spinlocks(1); oops_enter(); @@ -396,7 +396,7 @@ void parisc_terminate(char *msg, struct pt_regs *regs, int code, unsigned long o { static DEFINE_SPINLOCK(terminate_lock); - oops_in_progress = 1; + bust_spinlocks(1); set_eiem(0); local_irq_disable();
Use bust_spinlocks() function to set oops_in_progress. Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> --- arch/parisc/kernel/traps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)