| Message ID | 20200223192942.18420-11-qais.yousef@arm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,01/15] cpu: Add new {add,remove}_cpu() functions | expand |
diff --git a/arch/parisc/kernel/processor.c b/arch/parisc/kernel/processor.c index 13f771f74ee3..7f2d0c0ecc80 100644 --- a/arch/parisc/kernel/processor.c +++ b/arch/parisc/kernel/processor.c @@ -212,7 +212,7 @@ static int __init processor_probe(struct parisc_device *dev) #ifdef CONFIG_SMP if (cpuid) { set_cpu_present(cpuid, true); - cpu_up(cpuid); + add_cpu(cpuid); } #endif
The core device API performs extra housekeeping bits that are missing from directly calling cpu_up/down. See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and serialization during LPM") for an example description of what might go wrong. This also prepares to make cpu_up/down a private interface for anything but the cpu subsystem. Acked-by: Helge Deller <deller@gmx.de> Signed-off-by: Qais Yousef <qais.yousef@arm.com> CC: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com> CC: Helge Deller <deller@gmx.de> CC: Richard Fontana <rfontana@redhat.com> CC: Armijn Hemel <armijn@tjaldur.nl> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> CC: Thomas Gleixner <tglx@linutronix.de> CC: linux-parisc@vger.kernel.org CC: linux-kernel@vger.kernel.org --- Helge, this now uses add_cpu() which you should be CCed on. I wasn't sure if I can keep your Ack or remove it in this case. Please let me know if you need more clarification. arch/parisc/kernel/processor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)