| Message ID | 208280b55a359db78eecee720799955f2043fb49.1503162439.git.arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Sat, Aug 19, 2017 at 10:38:41PM +0530, Arvind Yadav wrote: > parisc_device_id are not supposed to change at runtime. All functions > working with parisc_device_id provided by <asm/parisc-device.h> work > with > const parisc_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > drivers/parport/parport_gsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This has already been done by f0973443bef7 ("parisc/parport_gsc: Fix section mismatches") -- Regards Sudip -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/parport/parport_gsc.c b/drivers/parport/parport_gsc.c index 3858b87..8be1a0c 100644 --- a/drivers/parport/parport_gsc.c +++ b/drivers/parport/parport_gsc.c @@ -403,7 +403,7 @@ static int parport_remove_chip(struct parisc_device *dev) return 0; } -static struct parisc_device_id parport_tbl[] = { +static const struct parisc_device_id parport_tbl[] = { { HPHW_FIO, HVERSION_REV_ANY_ID, HVERSION_ANY_ID, 0x74 }, { 0, } };
parisc_device_id are not supposed to change at runtime. All functions working with parisc_device_id provided by <asm/parisc-device.h> work with const parisc_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/parport/parport_gsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)