From patchwork Sun Jan 13 22:04:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John David Anglin X-Patchwork-Id: 1970731 Return-Path: X-Original-To: patchwork-linux-parisc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id A3DCD3FD86 for ; Sun, 13 Jan 2013 22:05:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755937Ab3AMWFM (ORCPT ); Sun, 13 Jan 2013 17:05:12 -0500 Received: from [65.55.111.174] ([65.55.111.174]:63027 "EHLO blu0-omc4-s35.blu0.hotmail.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1755927Ab3AMWFL (ORCPT ); Sun, 13 Jan 2013 17:05:11 -0500 Received: from BLU0-SMTP29 ([65.55.111.137]) by blu0-omc4-s35.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Sun, 13 Jan 2013 14:04:50 -0800 X-EIP: [G5n0KSTTuAZ6RHbR7QiLPlX9ooqGUpbr] X-Originating-Email: [dave.anglin@bell.net] Message-ID: Received: from [192.168.2.10] ([69.158.129.215]) by BLU0-SMTP29.blu0.hotmail.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 13 Jan 2013 14:04:50 -0800 From: John David Anglin To: linux-parisc List Subject: [PATCH] parisc: Fix comment describing setup of access rights in entry.S MIME-Version: 1.0 (Apple Message framework v936) Date: Sun, 13 Jan 2013 17:04:18 -0500 CC: Helge Deller , "James E.J. Bottomley" X-Mailer: Apple Mail (2.936) X-OriginalArrivalTime: 13 Jan 2013 22:04:50.0550 (UTC) FILETIME=[02305960:01CDF1DA] Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org This comment describes incredibly subtle code, so it should be right! Signed-off-by: John David Anglin Dave --- John David Anglin dave.anglin@bell.net diff --git a/arch/parisc/kernel/entry.S b/arch/parisc/kernel/entry.S index eb7850b..7c96489 100644 --- a/arch/parisc/kernel/entry.S +++ b/arch/parisc/kernel/entry.S @@ -483,7 +483,7 @@ * B <-> _PAGE_DMB (memory break) * * Then incredible subtlety: The access rights are - * _PAGE_GATEWAY _PAGE_EXEC _PAGE_READ + * _PAGE_GATEWAY, _PAGE_EXEC and _PAGE_WRITE * See 3-14 of the parisc 2.0 manual * * Finally, _PAGE_READ goes in the top bit of PL1 (so we @@ -493,7 +493,7 @@ /* PAGE_USER indicates the page can be read with user privileges, * so deposit X1|11 to PL1|PL2 (remember the upper bit of PL1 - * contains _PAGE_READ */ + * contains _PAGE_READ) */ extrd,u,*= \pte,_PAGE_USER_BIT+32,1,%r0 depdi 7,11,3,\prot /* If we're a gateway page, drop PL2 back to zero for promotion