From patchwork Tue Aug 4 20:27:07 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 39196 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n74KRCFM018134 for ; Tue, 4 Aug 2009 20:27:12 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932387AbZHDU1K (ORCPT ); Tue, 4 Aug 2009 16:27:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932342AbZHDU1J (ORCPT ); Tue, 4 Aug 2009 16:27:09 -0400 Received: from mgw1.diku.dk ([130.225.96.91]:42826 "EHLO mgw1.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932143AbZHDU1I (ORCPT ); Tue, 4 Aug 2009 16:27:08 -0400 Received: from localhost (localhost [127.0.0.1]) by mgw1.diku.dk (Postfix) with ESMTP id EEE9452C325; Tue, 4 Aug 2009 22:27:08 +0200 (CEST) X-Virus-Scanned: amavisd-new at diku.dk Received: from mgw1.diku.dk ([127.0.0.1]) by localhost (mgw1.diku.dk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hQnrI3pNnh+C; Tue, 4 Aug 2009 22:27:07 +0200 (CEST) Received: from nhugin.diku.dk (nhugin.diku.dk [130.225.96.140]) by mgw1.diku.dk (Postfix) with ESMTP id 60A1252C313; Tue, 4 Aug 2009 22:27:07 +0200 (CEST) Received: from ask.diku.dk (ask.diku.dk [130.225.96.225]) by nhugin.diku.dk (Postfix) with ESMTP id 8B3216DF8B3; Tue, 4 Aug 2009 22:26:12 +0200 (CEST) Received: by ask.diku.dk (Postfix, from userid 3767) id 4AC8A154E8C; Tue, 4 Aug 2009 22:27:07 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by ask.diku.dk (Postfix) with ESMTP id 48469154E41; Tue, 4 Aug 2009 22:27:07 +0200 (CEST) Date: Tue, 4 Aug 2009 22:27:07 +0200 (CEST) From: Julia Lawall To: Helge Deller , Kyle McMartin , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] arch/parisc: correct use of SHF_ALLOC Message-ID: MIME-Version: 1.0 Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org From: Julia Lawall SHF_ALLOC is suitable for testing against the sh_flags field, not the sh_type field. Signed-off-by: Julia Lawall --- arch/parisc/kernel/module.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/parisc/kernel/module.c b/arch/parisc/kernel/module.c index ef5caf2..c904817 100644 --- a/arch/parisc/kernel/module.c +++ b/arch/parisc/kernel/module.c @@ -853,7 +853,7 @@ int module_finalize(const Elf_Ehdr *hdr, * ourselves */ for (i = 1; i < hdr->e_shnum; i++) { if(sechdrs[i].sh_type == SHT_SYMTAB - && (sechdrs[i].sh_type & SHF_ALLOC)) { + && (sechdrs[i].sh_flags & SHF_ALLOC)) { int strindex = sechdrs[i].sh_link; /* FIXME: AWFUL HACK * The cast is to drop the const from