| Message ID | a4423d670904010244q1cfbce88qaa635d8e4070db07@mail.gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wed, Apr 01, 2009 at 01:44:08PM +0400, Alexander Beregalov wrote: > Fixes this build error: > arch/parisc/kernel/pdc_cons.c:117: error: '__PAGE_OFFSET' undeclared > (first use in this function) > > Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com> Huh. Nice. More patches to arch/parisc that didn't go through me that break things. Applied, thanks again Alexander. cheers, Kyle -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2009/4/1 Kyle McMartin <kyle@mcmartin.ca>: > On Wed, Apr 01, 2009 at 01:44:08PM +0400, Alexander Beregalov wrote: >> Fixes this build error: >> arch/parisc/kernel/pdc_cons.c:117: error: '__PAGE_OFFSET' undeclared >> (first use in this function) >> >> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com> > > Huh. Nice. More patches to arch/parisc that didn't go through me that > break things. > > Applied, thanks again Alexander. Hi Kyle Actually the patch does not fix build. It fails with message "asm-parisc/page.h is not exported". I do not know what it means. Should we include page.h in pdc_cons.c instead of pdc.h ? -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Apr 01, 2009 at 07:06:41PM +0400, Alexander Beregalov wrote: > 2009/4/1 Kyle McMartin <kyle@mcmartin.ca>: > > On Wed, Apr 01, 2009 at 01:44:08PM +0400, Alexander Beregalov wrote: > >> Fixes this build error: > >> arch/parisc/kernel/pdc_cons.c:117: error: '__PAGE_OFFSET' undeclared > >> (first use in this function) > >> > >> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com> > > > > Huh. Nice. More patches to arch/parisc that didn't go through me that > > break things. > > > > Applied, thanks again Alexander. > > Hi Kyle > > Actually the patch does not fix build. It fails with message > "asm-parisc/page.h is not exported". > I do not know what it means. > Should we include page.h in pdc_cons.c instead of pdc.h ? > Ah, the <asm/page.h> include needs to be inside __KERNEL__. Care to resend? cheers, Kyle -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/parisc/include/asm/pdc.h b/arch/parisc/include/asm/pdc.h index a26e98d..fde8045 100644 --- a/arch/parisc/include/asm/pdc.h +++ b/arch/parisc/include/asm/pdc.h @@ -340,6 +340,7 @@ #if !defined(__ASSEMBLY__) #include <linux/types.h> +#include <asm/page.h> #ifdef __KERNEL__ -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
Fixes this build error: arch/parisc/kernel/pdc_cons.c:117: error: '__PAGE_OFFSET' undeclared (first use in this function) Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com> --- arch/parisc/include/asm/pdc.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html