[0/6] Improve link speed presentation process

Message

Yicong Yang Jan. 15, 2020, 9:04 a.m. UTC

In this series:
1. Add 32 GT/s decoding in some macros as a complementary
2. Remove redundancy in speed presentation process and improve the codes.

Currently We use switch-case statements to acquire the speed
string according to the pci bus speed in current_link_speed_show()
and pcie_get_speed_cap(). It leads to redundant and when new
standard comes, we have to add cases in the related functions,
which is easy to omit at somewhere.

Abstract the judge statements out. Use macros and pci speed
arrays instead. Then only the macros and arrays need to be
extended when next generation comes.

Link:
https://lore.kernel.org/linux-pci/[e-mail]/
https://lore.kernel.org/linux-pci/[e-mail]/


Yicong Yang (6):
  PCI: add 32 GT/s decoding in some macros
  PCI: Make pci_bus_speed_strings[] public
  PCI: Add comments for link speed info arrays
  PCI: Improve and rename PCIE_SPEED2STR macro
  PCI: Add PCIE_LNKCAP2_SLS2SPEED macro
  PCI: Reduce redundancy in current_link_speed_show()

 drivers/pci/pci-sysfs.c | 26 ++++----------------------
 drivers/pci/pci.c       | 23 +++++++----------------
 drivers/pci/pci.h       | 22 +++++++++++++++-------
 drivers/pci/probe.c     | 37 +++++++++++++++++++++++++++++++++++++
 drivers/pci/slot.c      | 39 +++------------------------------------
 5 files changed, 66 insertions(+), 81 deletions(-)

--
2.8.1

Comments

Yicong Yang Feb. 5, 2020, 9:37 a.m. UTC | #1

Hi Bjorn,

would you mind giving some comments to help me get these patches merged?

Thanks,
Yicong Yang

On 2020/1/15 17:04, Yicong Yang wrote:
> In this series:
> 1. Add 32 GT/s decoding in some macros as a complementary
> 2. Remove redundancy in speed presentation process and improve the codes.
>
> Currently We use switch-case statements to acquire the speed
> string according to the pci bus speed in current_link_speed_show()
> and pcie_get_speed_cap(). It leads to redundant and when new
> standard comes, we have to add cases in the related functions,
> which is easy to omit at somewhere.
>
> Abstract the judge statements out. Use macros and pci speed
> arrays instead. Then only the macros and arrays need to be
> extended when next generation comes.
>
> Link:
> https://lore.kernel.org/linux-pci/[e-mail]/
> https://lore.kernel.org/linux-pci/[e-mail]/
>
>
> Yicong Yang (6):
>   PCI: add 32 GT/s decoding in some macros
>   PCI: Make pci_bus_speed_strings[] public
>   PCI: Add comments for link speed info arrays
>   PCI: Improve and rename PCIE_SPEED2STR macro
>   PCI: Add PCIE_LNKCAP2_SLS2SPEED macro
>   PCI: Reduce redundancy in current_link_speed_show()
>
>  drivers/pci/pci-sysfs.c | 26 ++++----------------------
>  drivers/pci/pci.c       | 23 +++++++----------------
>  drivers/pci/pci.h       | 22 +++++++++++++++-------
>  drivers/pci/probe.c     | 37 +++++++++++++++++++++++++++++++++++++
>  drivers/pci/slot.c      | 39 +++------------------------------------
>  5 files changed, 66 insertions(+), 81 deletions(-)
>
> --
> 2.8.1
>
>
> .
>