[v11,0/3] PCI: uniphier: Add PME/AER support for UniPhier PCIe host controller

Message

Kunihiko Hayashi April 22, 2021, 5:04 p.m. UTC

This adds a new function called by MSI handler in DesignWare PCIe framework,
that invokes PME and AER funcions to detect the factor from SoC-dependent
registers.

Changes since v10:
- Fix comment style in the header
- Fix "virq" and "vIRQ" in variable name and description to "irq" and "IRQ"

Changes since v9:
- Fix the description of pcie_prot_service_get_irq()

Changes since v8:
- Add uniphier_pcie_host_init_complete() that finds PME/AER IRQ number
  after calling dw_pcie_host_init()
- Add conditions to depend on CONFIG_PCIE_PME and CONFIG_PCIEAER instead
  of CONFIG_PCIEPORTBUS
- Add Acked-by: line to portdrv patch

Changes since v7:
- Add Reviewed-by: line to 1st and 3rd patches

Changes since v6:
- Separate patches for iATU and phy error from this series
- Add Reviewed-by: line to dwc patch

Changes since v5:
- Add pcie_port_service_get_irq() function to pcie/portdrv
- Call pcie_port_service_get_irq() to get IRQ interrupt number for PME/AER
- Rebase to the latest linux-next branch,
  and remove devm_platform_ioremap_resource_byname() replacement patch

Changes since v4:
- Add Acked-by: line to dwc patch

Changes since v3:
- Move msi_host_isr() call into dw_handle_msi_irq()
- Move uniphier_pcie_misc_isr() call into the guard of chained_irq
- Use a bool argument is_msi instead of pci_msi_enabled()
- Consolidate handler calls for the same interrupt
- Fix typos in commit messages

Changes since v2:
- Avoid printing phy error message in case of EPROBE_DEFER
- Fix iATU register mapping method
- dt-bindings: Add Acked-by: line
- Fix typos in commit messages
- Use devm_platform_ioremap_resource_byname()

Changes since v1:
- Add check if struct resource is NULL
- Fix warning in the type of dev_err() argument

Kunihiko Hayashi (3):
  PCI: portdrv: Add pcie_port_service_get_irq() function
  PCI: dwc: Add msi_host_isr() callback
  PCI: uniphier: Add misc interrupt handler to invoke PME and AER

 drivers/pci/controller/dwc/pcie-designware-host.c |   3 +
 drivers/pci/controller/dwc/pcie-designware.h      |   1 +
 drivers/pci/controller/dwc/pcie-uniphier.c        | 105 +++++++++++++++++++---
 drivers/pci/pcie/portdrv.h                        |   1 +
 drivers/pci/pcie/portdrv_core.c                   |  16 ++++
 5 files changed, 112 insertions(+), 14 deletions(-)

Comments

Kunihiko Hayashi May 19, 2021, 4 a.m. UTC | #1

Gentle Ping.
Are there any comments about this series?

Thank you,


On 2021/04/23 2:04, Kunihiko Hayashi wrote:
> This adds a new function called by MSI handler in DesignWare PCIe framework,
> that invokes PME and AER funcions to detect the factor from SoC-dependent
> registers.
> 
> Changes since v10:
> - Fix comment style in the header
> - Fix "virq" and "vIRQ" in variable name and description to "irq" and "IRQ"
> 
> Changes since v9:
> - Fix the description of pcie_prot_service_get_irq()
> 
> Changes since v8:
> - Add uniphier_pcie_host_init_complete() that finds PME/AER IRQ number
>    after calling dw_pcie_host_init()
> - Add conditions to depend on CONFIG_PCIE_PME and CONFIG_PCIEAER instead
>    of CONFIG_PCIEPORTBUS
> - Add Acked-by: line to portdrv patch
> 
> Changes since v7:
> - Add Reviewed-by: line to 1st and 3rd patches
> 
> Changes since v6:
> - Separate patches for iATU and phy error from this series
> - Add Reviewed-by: line to dwc patch
> 
> Changes since v5:
> - Add pcie_port_service_get_irq() function to pcie/portdrv
> - Call pcie_port_service_get_irq() to get IRQ interrupt number for PME/AER
> - Rebase to the latest linux-next branch,
>    and remove devm_platform_ioremap_resource_byname() replacement patch
> 
> Changes since v4:
> - Add Acked-by: line to dwc patch
> 
> Changes since v3:
> - Move msi_host_isr() call into dw_handle_msi_irq()
> - Move uniphier_pcie_misc_isr() call into the guard of chained_irq
> - Use a bool argument is_msi instead of pci_msi_enabled()
> - Consolidate handler calls for the same interrupt
> - Fix typos in commit messages
> 
> Changes since v2:
> - Avoid printing phy error message in case of EPROBE_DEFER
> - Fix iATU register mapping method
> - dt-bindings: Add Acked-by: line
> - Fix typos in commit messages
> - Use devm_platform_ioremap_resource_byname()
> 
> Changes since v1:
> - Add check if struct resource is NULL
> - Fix warning in the type of dev_err() argument
> 
> Kunihiko Hayashi (3):
>    PCI: portdrv: Add pcie_port_service_get_irq() function
>    PCI: dwc: Add msi_host_isr() callback
>    PCI: uniphier: Add misc interrupt handler to invoke PME and AER
> 
>   drivers/pci/controller/dwc/pcie-designware-host.c |   3 +
>   drivers/pci/controller/dwc/pcie-designware.h      |   1 +
>   drivers/pci/controller/dwc/pcie-uniphier.c        | 105 +++++++++++++++++++---
>   drivers/pci/pcie/portdrv.h                        |   1 +
>   drivers/pci/pcie/portdrv_core.c                   |  16 ++++
>   5 files changed, 112 insertions(+), 14 deletions(-)
>