| Message ID | 20180730134316.11719-1-lorenzo.pieralisi@arm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | PCI: mobiveil: Misc fixes | expand |
On Mon, Jul 30, 2018 at 02:43:13PM +0100, Lorenzo Pieralisi wrote: > Subrahmanya, > > I put together this series so that the Mobiveil controller driver > can compile (successfully). Please review and ack as soon as possible > since the current situation is a bit embarassing to be honest, we > should be sending these patches as fixes this week so that they > can make it for v4.18, currently the driver is in the kernel for > nothing. There doesn't seem to be much interest in the Mobiveil driver (the last patch I see was on May 10), and as you say, it's not even in the Makefile, so it has gotten zero testing or even building. Should we just drop the driver and see if anybody wants to try again next cycle? I'm a little hesitant about flipping the switch to enable a brand-new driver this late in the cycle. Bjorn
On Tue, Jul 31, 2018 at 11:56:00AM -0500, Bjorn Helgaas wrote: > On Mon, Jul 30, 2018 at 02:43:13PM +0100, Lorenzo Pieralisi wrote: > > Subrahmanya, > > > > I put together this series so that the Mobiveil controller driver > > can compile (successfully). Please review and ack as soon as possible > > since the current situation is a bit embarassing to be honest, we > > should be sending these patches as fixes this week so that they > > can make it for v4.18, currently the driver is in the kernel for > > nothing. > > There doesn't seem to be much interest in the Mobiveil driver (the > last patch I see was on May 10), and as you say, it's not even in the > Makefile, so it has gotten zero testing or even building. > > Should we just drop the driver and see if anybody wants to try again > next cycle? I'm a little hesitant about flipping the switch to enable > a brand-new driver this late in the cycle. I totally share your concern - I do not know what's the best way to drop it but I think that reverting it is sensible given what this series has to do to enable it in the first place. Thanks, Lorenzo
Lorenzo, Please go ahead. Acked by: Subrahmanya lingappa Thanks for this. Subrahmanya On Mon 30 Jul, 2018, 7:13 PM Lorenzo Pieralisi, <lorenzo.pieralisi@arm.com> wrote: > Subrahmanya, > > I put together this series so that the Mobiveil controller driver > can compile (successfully). Please review and ack as soon as possible > since the current situation is a bit embarassing to be honest, we > should be sending these patches as fixes this week so that they > can make it for v4.18, currently the driver is in the kernel for > nothing. > > Thank you > Lorenzo > > Cc: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in> > Cc: Bjorn Helgaas <bhelgaas@google.com> > > Lorenzo Pieralisi (3): > PCI: mobiveil: Fix struct mobiveil_pcie.pcie_reg_base address type > PCI: mobiveil: Add missing ../pci.h include > PCI: mobiveil: Add Kconfig/Makefile entries > > drivers/pci/controller/Kconfig | 10 ++++++++++ > drivers/pci/controller/Makefile | 1 + > drivers/pci/controller/pcie-mobiveil.c | 4 +++- > 3 files changed, 14 insertions(+), 1 deletion(-) > > -- > 2.15.0 > > <div dir="auto">Lorenzo,<div dir="auto">Please go ahead.</div><div dir="auto">Acked by: Subrahmanya lingappa</div><div dir="auto"><br></div><div dir="auto">Thanks for this.</div><div dir="auto">Subrahmanya</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon 30 Jul, 2018, 7:13 PM Lorenzo Pieralisi, <<a href="mailto:lorenzo.pieralisi@arm.com">lorenzo.pieralisi@arm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Subrahmanya,<br> <br> I put together this series so that the Mobiveil controller driver<br> can compile (successfully). Please review and ack as soon as possible<br> since the current situation is a bit embarassing to be honest, we<br> should be sending these patches as fixes this week so that they<br> can make it for v4.18, currently the driver is in the kernel for<br> nothing.<br> <br> Thank you<br> Lorenzo<br> <br> Cc: Subrahmanya Lingappa <<a href="mailto:l.subrahmanya@mobiveil.co.in" target="_blank" rel="noreferrer">l.subrahmanya@mobiveil.co.in</a>><br> Cc: Bjorn Helgaas <<a href="mailto:bhelgaas@google.com" target="_blank" rel="noreferrer">bhelgaas@google.com</a>><br> <br> Lorenzo Pieralisi (3):<br> PCI: mobiveil: Fix struct mobiveil_pcie.pcie_reg_base address type<br> PCI: mobiveil: Add missing ../pci.h include<br> PCI: mobiveil: Add Kconfig/Makefile entries<br> <br> drivers/pci/controller/Kconfig | 10 ++++++++++<br> drivers/pci/controller/Makefile | 1 +<br> drivers/pci/controller/pcie-mobiveil.c | 4 +++-<br> 3 files changed, 14 insertions(+), 1 deletion(-)<br> <br> -- <br> 2.15.0<br> <br> </blockquote></div>