From patchwork Fri Aug 31 17:33:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dennis Dalessandro X-Patchwork-Id: 10584273 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3FEFD14E1 for ; Fri, 31 Aug 2018 17:33:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 315542C1BC for ; Fri, 31 Aug 2018 17:33:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2F8502C21B; Fri, 31 Aug 2018 17:33:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE7DD2C1D6 for ; Fri, 31 Aug 2018 17:33:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726915AbeHaVm0 (ORCPT ); Fri, 31 Aug 2018 17:42:26 -0400 Received: from mga17.intel.com ([192.55.52.151]:10601 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726275AbeHaVm0 (ORCPT ); Fri, 31 Aug 2018 17:42:26 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Aug 2018 10:33:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,312,1531810800"; d="scan'208";a="77077574" Received: from scymds01.sc.intel.com ([10.82.194.37]) by FMSMGA003.fm.intel.com with ESMTP; 31 Aug 2018 10:33:55 -0700 Received: from scvm10.sc.intel.com (scvm10.sc.intel.com [10.82.195.27]) by scymds01.sc.intel.com with ESMTP id w7VHXs97008618; Fri, 31 Aug 2018 10:33:54 -0700 Received: from scvm10.sc.intel.com (localhost [127.0.0.1]) by scvm10.sc.intel.com with ESMTP id w7VHXsuw022626; Fri, 31 Aug 2018 10:33:54 -0700 Subject: [PATCH for-rc 0/2] IB/hfi1: PCI bug due to pci core changes From: Dennis Dalessandro To: bhelgaas@google.com, jgg@ziepe.ca, dledford@redhat.com Cc: Sinan Kaya , "Michael J. Ruhl" , linux-pci@vger.kernel.org, linux-rdma@vger.kernel.org Date: Fri, 31 Aug 2018 10:33:54 -0700 Message-ID: <20180831173132.21741.25892.stgit@scvm10.sc.intel.com> User-Agent: StGit/0.17.1-18-g2e886-dirty MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Bjorn, Doug and Jason, As discussed on the pci list [1] our driver was broken with the following three changes in 4.19 merge window: c6a44ba950d1 ("PCI: Rename pci_try_reset_bus() to pci_reset_bus()") 409888e0966e ("IB/hfi1: Use pci_try_reset_bus() for initiating PCI Secondary Bus Reset") 811c5cb37df4 ("PCI: Unify try slot and bus reset API") Ideally I'd like to see those patches reverted but we could also go with something like the following series. I know there is a desire to have a more clean API but since this is already the rc phase I think that is best delayed. Clearly the first attempt at an API clean up did not work out so well. I'm not sure how you maintainers want to handle this since the fix straddles both subsystems so I'm sending it to both linux-rdma and linux-pci. At the request of discussion on the linux-pci list I have also filed a bug [2]. [1] https://marc.info/?l=linux-pci&m=153539692917785&w=2 [2] https://bugzilla.kernel.org/show_bug.cgi?id=200985 Thanks --- Dennis Dalessandro (2): PCI: Fix faulty logic in pci_reset_bus() IB/hfi1,PCI: Allow bus reset while probing drivers/infiniband/hw/hfi1/pcie.c | 11 ++++------- drivers/pci/pci.c | 3 ++- include/linux/pci.h | 3 +++ 3 files changed, 9 insertions(+), 8 deletions(-) -- -Denny