mbox series

[0/2] lspci: Add lspci support to decode AIDA64 and dmesg log files

Message ID 20190704000819.25050-1-skunberg.kelsey@gmail.com (mailing list archive)
Headers show
Series lspci: Add lspci support to decode AIDA64 and dmesg log files | expand

Message

Kelsey July 4, 2019, 12:08 a.m. UTC
Add lspci support to decode AIDA64 log files and dmesg log files with
"pci=earlydump" parameter to output PCI configuration space information.

	Patch 1: Add lspci support to decode AIDA64 log file.

	AIDA64 log file included in patch for testing. Use the following
	command to run:

		lspci -F tests/aida64-dump


	Patch 2: Add lspci support to decode dmesg log file with
	"pci=earlydump" parameter.

	dmesg log file with "pci=earlydump" included in patch for
	testing. Use the following command to run:

                lspci -F tests/dmesg-dump





Bjorn Helgaas (2):
  lspci: Add lspci support to decode an AIDA64 log file
  lspci: Add lspci support to decode "pci=earlydump" output

 lib/dump.c        |   96 ++-
 tests/aida64-dump |  954 ++++++++++++++++++++++++
 tests/dmesg-dump  | 1795 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 2812 insertions(+), 33 deletions(-)
 create mode 100644 tests/aida64-dump
 create mode 100644 tests/dmesg-dump

Comments

Martin Mareš Jan. 21, 2020, 9 p.m. UTC | #1
Hello!

> Add lspci support to decode AIDA64 log files and dmesg log files with
> "pci=earlydump" parameter to output PCI configuration space information.
> 
> 	Patch 1: Add lspci support to decode AIDA64 log file.
> 
> 	AIDA64 log file included in patch for testing. Use the following
> 	command to run:
> 
> 		lspci -F tests/aida64-dump
> 
> 
> 	Patch 2: Add lspci support to decode dmesg log file with
> 	"pci=earlydump" parameter.
> 
> 	dmesg log file with "pci=earlydump" included in patch for
> 	testing. Use the following command to run:
> 
>                 lspci -F tests/dmesg-dump

Generally, I like the idea of adding these two file formats
to the dump back-end.

However, combining parsers of all three formats to a single block
of code looks pretty scary. With a couple of formats more, this would
become an unmaintable mess.

I would prefer separate parsers and explicit selection of input format.
If you want any help with how to integrate that to libpci/lspci, please
let me know.

Also, please document which formats are supported.

				Have a nice fortnight