| Message ID | 20201126011816.711106-1-helgaas@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Simplify PCIe native ownership | expand |
On 11/25/20 5:18 PM, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@google.com> > > This is Sathy's work with a few tweaks on top. > > I dropped the DPC pcie_ports_dpc_native changes for now just because I > haven't had time to understand it all. We currently ignore the > OSC_PCI_EXPRESS_DPC_CONTROL bit, which seems wrong. We might want to start > looking at it, but we should try to make that a separate patch that's as > small as possible. Along with above patch, you also left following two cleanup patches. Is this intentional? Following fixes have no dependency on pcie_ports_dpc_native change. [PATCH v11 4/5] PCI/portdrv: Remove redundant pci_aer_available() check in DPC enable logic [PATCH v11 5/5] PCI/DPC: Move AER/DPC dependency checks out of DPC driver > > Changes since v11: > * Add bugfix for DPC with no AER Capability > * Split OSC_OWNER trivial changes from pcie_ports_native changes > * Temporarily drop pcie_ports_dpc_native changes > > v11 posting: https://lore.kernel.org/r/cover.1603766889.git.sathyanarayanan.kuppuswamy@linux.intel.com > > Bjorn Helgaas (2): > PCI/DPC: Ignore devices with no AER Capability > PCI/ACPI: Centralize pci_aer_available() checking > > Kuppuswamy Sathyanarayanan (3): > PCI: Assume control of portdrv-related features only when portdrv > enabled > PCI/ACPI: Tidy _OSC control bit checking > PCI/ACPI: Centralize pcie_ports_native checking > > drivers/acpi/pci_root.c | 49 ++++++++++++++++++++++++------- > drivers/pci/hotplug/pciehp_core.c | 2 +- > drivers/pci/pci-acpi.c | 3 -- > drivers/pci/pcie/aer.c | 2 +- > drivers/pci/pcie/dpc.c | 3 ++ > drivers/pci/pcie/portdrv_core.c | 9 ++---- > drivers/pci/probe.c | 6 ++-- > 7 files changed, 50 insertions(+), 24 deletions(-) >
Hi Bjorn, On 11/25/20 7:48 PM, Kuppuswamy, Sathyanarayanan wrote: > Along with above patch, you also left following two cleanup patches. Is this > intentional? Following fixes have no dependency on pcie_ports_dpc_native change. > > [PATCH v11 4/5] PCI/portdrv: Remove redundant pci_aer_available() check in DPC enable logic > [PATCH v11 5/5] PCI/DPC: Move AER/DPC dependency checks out of DPC driver Any comment? If you want me to add these patches in my re-submission, please let me know.
Hi Bjorn, On 11/30/20 5:11 PM, Kuppuswamy, Sathyanarayanan wrote: > Hi Bjorn, > > On 11/25/20 7:48 PM, Kuppuswamy, Sathyanarayanan wrote: >> Along with above patch, you also left following two cleanup patches. Is this >> intentional? Following fixes have no dependency on pcie_ports_dpc_native change. >> >> [PATCH v11 4/5] PCI/portdrv: Remove redundant pci_aer_available() check in DPC enable logic >> [PATCH v11 5/5] PCI/DPC: Move AER/DPC dependency checks out of DPC driver > > Any comment? If you want me to add these patches in my re-submission, please > let me know. Gentle ping. Any comments? >
From: Bjorn Helgaas <bhelgaas@google.com> This is Sathy's work with a few tweaks on top. I dropped the DPC pcie_ports_dpc_native changes for now just because I haven't had time to understand it all. We currently ignore the OSC_PCI_EXPRESS_DPC_CONTROL bit, which seems wrong. We might want to start looking at it, but we should try to make that a separate patch that's as small as possible. Changes since v11: * Add bugfix for DPC with no AER Capability * Split OSC_OWNER trivial changes from pcie_ports_native changes * Temporarily drop pcie_ports_dpc_native changes v11 posting: https://lore.kernel.org/r/cover.1603766889.git.sathyanarayanan.kuppuswamy@linux.intel.com Bjorn Helgaas (2): PCI/DPC: Ignore devices with no AER Capability PCI/ACPI: Centralize pci_aer_available() checking Kuppuswamy Sathyanarayanan (3): PCI: Assume control of portdrv-related features only when portdrv enabled PCI/ACPI: Tidy _OSC control bit checking PCI/ACPI: Centralize pcie_ports_native checking drivers/acpi/pci_root.c | 49 ++++++++++++++++++++++++------- drivers/pci/hotplug/pciehp_core.c | 2 +- drivers/pci/pci-acpi.c | 3 -- drivers/pci/pcie/aer.c | 2 +- drivers/pci/pcie/dpc.c | 3 ++ drivers/pci/pcie/portdrv_core.c | 9 ++---- drivers/pci/probe.c | 6 ++-- 7 files changed, 50 insertions(+), 24 deletions(-)