From patchwork Sun Aug 22 16:10:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergio Paracuellos X-Patchwork-Id: 12451573 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 696C6C4320A for ; Sun, 22 Aug 2021 16:10:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52B7A61266 for ; Sun, 22 Aug 2021 16:10:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234339AbhHVQKu (ORCPT ); Sun, 22 Aug 2021 12:10:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229766AbhHVQKu (ORCPT ); Sun, 22 Aug 2021 12:10:50 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6FCEC061575; Sun, 22 Aug 2021 09:10:08 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id o15so8961449wmr.3; Sun, 22 Aug 2021 09:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZKBqCHTxnc7Q0ClnUW6EKDpt275rDtZm2ej5x81lpWg=; b=tvOB3/pEsSGuE+ELhD+3z9UC4+qrGSGWNyDO8q/VidQxcyQjhA9VfhQ99IkoPjleV1 Z8YDFw4SyzuME/ombY54tKs+c1gaT++/RPF6sezMSB0bPooyr9h/aZgx4sTNhP3mJ0pj L/HkFwkl27DSZ5SN5zxmHZuu2XUzuDuw98e0n+D5NCNfoNeJwAoLbl0mGk6oa5rHFJkA izvSbGReafL0pIiyRgVNowhyBWuVcm2EyVYPMkdJHfaLjjBFyWlyW3n3FNy0rbjwovA1 8maARhSw25Dxd2zaQ5U8eOilHLxlrLe9cpD/+z/cPqZCzmAJ6Meq2xko7fNKVJO9pqaI qmvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZKBqCHTxnc7Q0ClnUW6EKDpt275rDtZm2ej5x81lpWg=; b=OMmBR/RCqdexDaXYpgsvKcrqts1q/bOHU+BU5+OtU6xKPjT0jgWaLMuy8WAMffcI0g OmQcLP17AsmU6xMmKJ7x12z8fhiFk4eAcHC06rCQVfX+VDNfq6lSlxGhxRwFusq4J4D0 Gawa7kXlXxsD5YbGl7/8eHUR4ZdMrKhuH9wx3QAlypWpaQCQZbwZe/bU6CskrOOhN2eE /cTK63xRvbF413NEObxzy84ySZY9PIyq3XHuyt2obzV5i8DxyOrRAP/VTwmpLem7T5wX HRrSmThQp32jbOgpTmXFtaSlBvQdGlaSE1IQSlWzPbEzvZnViOef5ea9e4NDOqaIzvWH xpgg== X-Gm-Message-State: AOAM530M25wArrYHQlArwXCUsV5SROmn/R8+wTJvQQfCUn0PLcMHl8kY DZhB6gE5FWN9Rd76/Q/UevxFOzGJ2c8ftA== X-Google-Smtp-Source: ABdhPJy28SkPKG4ICKYRDfXpMUHqIXl88FdrF4ezDi+hCW232fgioMBznepHg62FgVhtRsP9GsDAqw== X-Received: by 2002:a05:600c:1ca9:: with SMTP id k41mr12326317wms.39.1629648607166; Sun, 22 Aug 2021 09:10:07 -0700 (PDT) Received: from localhost.localdomain (10.red-83-57-27.dynamicip.rima-tde.net. [83.57.27.10]) by smtp.gmail.com with ESMTPSA id y11sm14861976wru.0.2021.08.22.09.10.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Aug 2021 09:10:06 -0700 (PDT) From: Sergio Paracuellos To: tsbogend@alpha.franken.de Cc: bhelgaas@google.com, matthias.bgg@gmail.com, gregkh@linuxfoundation.org, linux-mips@vger.kernel.org, linux-pci@vger.kernel.org, linux-staging@lists.linux.dev, neil@brown.name, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/3] MIPS: ralink: properly handle pci IO resources Date: Sun, 22 Aug 2021 18:10:02 +0200 Message-Id: <20210822161005.22467-1-sergio.paracuellos@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi all, Defining PCI_IOBASE for MIPS ralink platform results in resource handling working but the addresses generated for IO access being wrong, because the iomap tries to ioremap it to a fixed virtual address (PCI_IOBASE), which can't work for KSEG1 addresses. To get it working this way, we would need to put PCI_IOBASE somewhere into KSEG2, which will create TLB entries for IO addresses, which most of the time isn't needed on MIPS because of access via KSEG1. Instead of doing that and taking into account that we need to get a valid IO address from 'pci_address_to_pio' and ralink platforms have IO addresses higher than 0xffff, the following approach will be preferred to get expected working behaviour from PCI core APIs and pci drivers working together: 1) Avoid to define PCI_IOBASE. 2) Set IO_SPACE_LIMIT to 0x1fffffff which is a valid range for this SoCs. 3) Return zero from 'pci_remap_iospace' if PCI_IOBASE is not defined. 3) Set ioport_resource end limit to this new IO_SPACE_LIMIT. Doing in this way we end up with a properly working PCI IO in ralink SoCs. These changes metioned above are in the three patches included in this series. Thanks in advance for your time and comments. Changes in v2 (only PATCH v2 2/3 afected): - Instead of avoid to call 'devm_pci_remap_iospace' fix 'pci_remap_iospace' to return zero for PCI_IOBASE not defined architectures. Bjorn, I don't know if I should add any kind of 'Fixes' tag for this or what is the way of handle this kind of changes inside the PCI tree. Thanks in advance for clarification. Sergio Paracuellos (3): MIPS: ralink: don't define PC_IOBASE but increase IO_SPACE_LIMIT PCI: fix 'pci_remap_iospace' for architectures with PCI_IOBASE not defined staging: mt7621-pci: set end limit for 'ioport_resource' arch/mips/include/asm/mach-ralink/spaces.h | 4 +--- drivers/pci/pci.c | 12 ++++++------ drivers/staging/mt7621-pci/pci-mt7621.c | 2 ++ 3 files changed, 9 insertions(+), 9 deletions(-)