| Message ID | 20210827083129.2781420-1-chenhuacai@loongson.cn (mailing list archive) |
|---|---|
| Headers | show |
| Series | PCI/VGA: Rework default VGA device selection | expand |
On Fri, Aug 27, 2021 at 04:31:19PM +0800, Huacai Chen wrote: > My original work is at [1]. > > Bjorn do some rework and extension in V2. It moves the VGA arbiter to > the PCI subsystem, fixes a few nits, and breaks a few pieces to make > the main patch a little smaller. > > V3 rewrite the commit log of the last patch (which is also summarized > by Bjorn). > > V4 split the last patch to two steps. > > All comments welcome! I'm hoping to apply something like this for v5.16. BUT as I mentioned in [2], I want the very first patch to be the very simple 2-line change to vga_arb_update_default_device() that actually fixes your problem. It makes no sense for that change to be at the very end, hidden in the middle of a bigger restructuring patch. [2] https://lore.kernel.org/r/20210825201704.GA3600046@bjorn-Precision-5520 > [1] https://lore.kernel.org/dri-devel/20210705100503.1120643-1-chenhuacai@loongson.cn/ > > Bjorn Helgaas (4): > PCI/VGA: Move vgaarb to drivers/pci > PCI/VGA: Replace full MIT license text with SPDX identifier > PCI/VGA: Use unsigned format string to print lock counts > PCI/VGA: Remove empty vga_arb_device_card_gone() > > Huacai Chen (6): > PCI/VGA: Move vga_arb_integrated_gpu() earlier in file > PCI/VGA: Prefer vga_default_device() > PCI/VGA: Split out vga_arb_update_default_device() > PCI/VGA: Log bridge control messages when adding devices > PCI/VGA: Rework default VGA device selection (Step 1) > PCI/VGA: Rework default VGA device selection (Step 2) > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > --- > drivers/gpu/vga/Kconfig | 19 --- > drivers/gpu/vga/Makefile | 1 - > drivers/pci/Kconfig | 19 +++ > drivers/pci/Makefile | 1 + > drivers/{gpu/vga => pci}/vgaarb.c | 269 ++++++++++++------------------ > 5 files changed, 126 insertions(+), 183 deletions(-) > rename drivers/{gpu/vga => pci}/vgaarb.c (90%) > -- > 2.27.0 >
Hi, Bjorn, On Fri, Sep 10, 2021 at 1:59 AM Bjorn Helgaas <helgaas@kernel.org> wrote: > > On Fri, Aug 27, 2021 at 04:31:19PM +0800, Huacai Chen wrote: > > My original work is at [1]. > > > > Bjorn do some rework and extension in V2. It moves the VGA arbiter to > > the PCI subsystem, fixes a few nits, and breaks a few pieces to make > > the main patch a little smaller. > > > > V3 rewrite the commit log of the last patch (which is also summarized > > by Bjorn). > > > > V4 split the last patch to two steps. > > > > All comments welcome! > > I'm hoping to apply something like this for v5.16. > > BUT as I mentioned in [2], I want the very first patch to be the very > simple 2-line change to vga_arb_update_default_device() that actually > fixes your problem. > > It makes no sense for that change to be at the very end, hidden in the > middle of a bigger restructuring patch. I think I should split the restructuring patch again, and sort the series to move important things to earlier patches. Let me try... Huacai > > [2] https://lore.kernel.org/r/20210825201704.GA3600046@bjorn-Precision-5520 > > > [1] https://lore.kernel.org/dri-devel/20210705100503.1120643-1-chenhuacai@loongson.cn/ > > > > Bjorn Helgaas (4): > > PCI/VGA: Move vgaarb to drivers/pci > > PCI/VGA: Replace full MIT license text with SPDX identifier > > PCI/VGA: Use unsigned format string to print lock counts > > PCI/VGA: Remove empty vga_arb_device_card_gone() > > > > Huacai Chen (6): > > PCI/VGA: Move vga_arb_integrated_gpu() earlier in file > > PCI/VGA: Prefer vga_default_device() > > PCI/VGA: Split out vga_arb_update_default_device() > > PCI/VGA: Log bridge control messages when adding devices > > PCI/VGA: Rework default VGA device selection (Step 1) > > PCI/VGA: Rework default VGA device selection (Step 2) > > > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > > --- > > drivers/gpu/vga/Kconfig | 19 --- > > drivers/gpu/vga/Makefile | 1 - > > drivers/pci/Kconfig | 19 +++ > > drivers/pci/Makefile | 1 + > > drivers/{gpu/vga => pci}/vgaarb.c | 269 ++++++++++++------------------ > > 5 files changed, 126 insertions(+), 183 deletions(-) > > rename drivers/{gpu/vga => pci}/vgaarb.c (90%) > > -- > > 2.27.0 > >